Bug 108474 – [Qt] Enable QML handling of crashed/unresponsive QtWebProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Milian Wolff]

See also: https://lists.webkit.org/pipermail/webkit-qt/2013-January/003410.html

Currently it is not possible to gracefully handle the case of a crashed/unresponsive QtWebProcess in WK2/QML. The idea is to add signals for that which would allow the QML developer to save any state that he might need, then trigger a reload and restore the old state or similar.

[Milian Wolff]

Created attachment 185771 [details]
Patch

[Michael Brüning]

The patch in principal looks okay to me, however, it will have  to be rewritten a bit because QtWebPageLoadClient no longer exists in that form, but has been folded into QQuickWebViewPrivate a while ago.

Also, we might need to have a WebKit2 owner cc'ed for the sign off when the patch has been rewritten.

[Milian Wolff]

Created attachment 191471 [details]
Patch

[Milian Wolff]

Ping? Can we get this accepted please?

[Jocelyn Turcotte]

Comment on attachment 191471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191471&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:507
> +    qWarning("WARNING: The web process has become unresponsive.");

I think that this isn't necessary, it can be noisy for applications using the signals directly.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:514
> +    qWarning("WARNING: The web process has become responsive.");

Even less value for this one :)

This looks good to me otherwise.

[Milian Wolff]

Created attachment 207864 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 207864 [details]
Patch

Clearing flags on attachment: 207864

Committed r153580: <http://trac.webkit.org/changeset/153580>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.