108470 – Building with MinGW compiler dies with gtest errors

Bug 108470 - Building with MinGW compiler dies with gtest errors

Summary: Building with MinGW compiler dies with gtest errors

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Platform (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-01-31 05:27 PST by tuxator
Modified:	2013-02-05 18:29 PST (History)
CC List:	2 users (show)

See Also:

Attachments
first try (552 bytes, patch) 2013-01-31 05:29 PST, tuxator	mrobinson: review-	Details \| Formatted Diff \| Diff
set stuff conditionall (1.42 KB, patch) 2013-02-05 08:58 PST, tuxator	no flags	Details \| Formatted Diff \| Diff
fix style (1.41 KB, patch) 2013-02-05 13:12 PST, tuxator	no flags	Details \| Formatted Diff \| Diff
Patch (1.56 KB, patch) 2013-02-05 13:45 PST, tuxator	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description tuxator 2013-01-31 05:27:27 PST

When trying to cross compie webkitgtk build dies with the following error

CXXLD    libWebCoreInternals.la
  CXX      Source/ThirdParty/gtest/src/Libraries_libgtest_la-gtest-all.lo
In file included from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40:0,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'void testing::internal::SleepMilliseconds(int)':
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:876:24: error: 'nanosleep' was not declared in this scope
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: At global scope:
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:980:3: error: 'pthread_t' does not name a type
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In constructor 'testing::internal::ThreadWithParam<T>::ThreadWithParam(testing::internal::ThreadWithParam<T>::UserThreadFunc, T, testing::internal::Notification*)':
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:955:5: error: 'thread_' was not declared in this scope
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:955:5: error: there are no arguments to 'pthread_create' that depend on a template parameter, so a declaration of 'pthread_create' must be available [-fpermissive]
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:955:5: note: (if you use '-fpermissive', G++ will accept your code, but allowing the use of an undeclared name is deprecated)
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In member function 'void testing::internal::ThreadWithParam<T>::Join()':
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:962:7: error: 'thread_' was not declared in this scope
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:962:7: error: there are no arguments to 'pthread_join' that depend on a template parameter, so a declaration of 'pthread_join' must be available [-fpermissive]
In file included from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40:0,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In member function 'void testing::internal::MutexBase::Unlock()':
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1021:14: error: no match for 'operator=' in '((testing::internal::MutexBase*)this)->testing::internal::MutexBase::owner_ = 0'
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1021:14: note: candidate is:
In file included from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987:0,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:583:3: note: testing::internal::ptw32_handle_t& testing::internal::ptw32_handle_t::operator=(const testing::internal::ptw32_handle_t&)
/usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:583:3: note:   no known conversion for argument 1 from 'int' to 'const testing::internal::ptw32_handle_t&'
In file included from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40:0,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In member function 'void testing::internal::MutexBase::AssertHeld() const':
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1028:5: error: no match for 'operator==' in '((const testing::internal::MutexBase*)this)->testing::internal::MutexBase::owner_ == testing::internal::pthread_self()'
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1028:5: note: candidate is:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/winnt.h:461:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/windef.h:139,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:69,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/guiddef.h:163:14: note: int testing::internal::operator==(const GUID&, const GUID&)
/usr/i686-w64-mingw32/sys-root/mingw/include/guiddef.h:163:14: note:   no known conversion for argument 1 from 'const pthread_t {aka const testing::internal::ptw32_handle_t}' to 'const GUID& {aka const testing::internal::_GUID&}'
In file included from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40:0,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In constructor 'testing::internal::Mutex::Mutex()':
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1056:14: error: no match for 'operator=' in '((testing::internal::Mutex*)this)->testing::internal::Mutex::<anonymous>.testing::internal::MutexBase::owner_ = 0'
./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1056:14: note: candidate is:
In file included from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987:0,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:583:3: note: testing::internal::ptw32_handle_t& testing::internal::ptw32_handle_t::operator=(const testing::internal::ptw32_handle_t&)
/usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:583:3: note:   no known conversion for argument 1 from 'int' to 'const testing::internal::ptw32_handle_t&'
In file included from ./Source/ThirdParty/gtest/src/gtest.cc:128:0,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:42:
./Source/ThirdParty/gtest/src/gtest-internal-inl.h: In member function 'void testing::internal::AutoHandle::Reset(testing::internal::HANDLE)':
./Source/ThirdParty/gtest/src/gtest-internal-inl.h:995:9: error: '::CloseHandle' has not been declared
./Source/ThirdParty/gtest/src/gtest-internal-inl.h:995:9: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1460:29: note:   'testing::internal::CloseHandle'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:42:0:
./Source/ThirdParty/gtest/src/gtest.cc: In function 'testing::internal::TimeInMillis testing::internal::GetTimeInMillis()':
./Source/ThirdParty/gtest/src/gtest.cc:782:26: error: cannot convert 'testing::internal::timeval*' to 'timeval*' for argument '1' to 'int gettimeofday(timeval*, void*)'
./Source/ThirdParty/gtest/src/gtest.cc: In function 'testing::AssertionResult testing::internal::{anonymous}::HRESULTFailureHelper(const char*, const char*, long int)':
./Source/ThirdParty/gtest/src/gtest.cc:1375:26: error: '::FormatMessageA' has not been declared
./Source/ThirdParty/gtest/src/gtest.cc:1375:26: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1548:27: note:   'testing::internal::FormatMessageA'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:42:0:
./Source/ThirdParty/gtest/src/gtest.cc: At global scope:
./Source/ThirdParty/gtest/src/gtest.cc:1971:39: error: variable or field 'AddExceptionThrownFailure' declared void
./Source/ThirdParty/gtest/src/gtest.cc:1971:39: error: 'DWORD' was not declared in this scope
./Source/ThirdParty/gtest/src/gtest.cc:1971:39: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:69:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/windef.h:117:27: note:   'testing::internal::DWORD'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:42:0:
./Source/ThirdParty/gtest/src/gtest.cc:1972:39: error: expected primary-expression before 'const'
./Source/ThirdParty/gtest/src/gtest.cc: In function 'void testing::PrintTestPartResult(const testing::TestPartResult&)':
./Source/ThirdParty/gtest/src/gtest.cc:2536:3: error: '::OutputDebugStringA' has not been declared
./Source/ThirdParty/gtest/src/gtest.cc:2536:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1916:26: note:   'testing::internal::OutputDebugStringA'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:42:0:
./Source/ThirdParty/gtest/src/gtest.cc:2537:3: error: '::OutputDebugStringA' has not been declared
./Source/ThirdParty/gtest/src/gtest.cc:2537:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1916:26: note:   'testing::internal::OutputDebugStringA'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:42:0:
./Source/ThirdParty/gtest/src/gtest.cc: In member function 'void testing::UnitTest::AddTestPartResult(testing::TestPartResult::Type, const char*, int, const testing::internal::String&, const testing::internal::String&)':
./Source/ThirdParty/gtest/src/gtest.cc:3603:18: error: 'DebugBreak' was not declared in this scope
./Source/ThirdParty/gtest/src/gtest.cc:3603:18: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1384:26: note:   'testing::internal::DebugBreak'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc: In member function 'virtual int testing::internal::WindowsDeathTest::Wait()':
./Source/ThirdParty/gtest/src/gtest-death-test.cc:558:11: error: '::WaitForMultipleObjects' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:558:11: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1404:27: note:   'testing::internal::WaitForMultipleObjects'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:580:3: error: '::WaitForSingleObject' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:580:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1403:27: note:   'testing::internal::WaitForSingleObject'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:584:3: error: '::GetExitCodeProcess' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:584:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1287:29: note:   'testing::internal::GetExitCodeProcess'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc: In member function 'virtual testing::internal::DeathTest::TestRole testing::internal::WindowsDeathTest::AssumeRole()':
./Source/ThirdParty/gtest/src/gtest-death-test.cc:615:3: error: '::CreatePipe' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:615:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1564:29: note:   'testing::internal::CreatePipe'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:622:23: error: '::CreateEventW' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:622:23: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1806:28: note:   'testing::internal::CreateEventW'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:638:33: error: '::GetCurrentProcessId' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:638:33: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1284:27: note:   'testing::internal::GetCurrentProcessId'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:646:3: error: '::GetModuleFileNameA' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:646:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1857:27: note:   'testing::internal::GetModuleFileNameA'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:652:40: error: '::GetCommandLineA' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:652:40: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1904:27: note:   'testing::internal::GetCommandLineA'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:666:28: error: '::GetStdHandle' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:666:28: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1441:28: note:   'testing::internal::GetStdHandle'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:667:29: error: '::GetStdHandle' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:667:29: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1441:28: note:   'testing::internal::GetStdHandle'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:668:28: error: '::GetStdHandle' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:668:28: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1441:28: note:   'testing::internal::GetStdHandle'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:671:3: error: '::CreateProcessA' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:671:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1893:29: note:   'testing::internal::CreateProcessA'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:683:3: error: '::CloseHandle' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:683:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1460:29: note:   'testing::internal::CloseHandle'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc: In function 'int testing::internal::GetStatusFileDescriptor(unsigned int, size_t, size_t)':
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1064:36: error: '::OpenProcess' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1064:36: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1282:28: note:   'testing::internal::OpenProcess'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1083:8: error: '::DuplicateHandle' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1083:8: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1461:29: note:   'testing::internal::DuplicateHandle'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1084:26: error: '::GetCurrentProcess' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1084:26: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1283:28: note:   'testing::internal::GetCurrentProcess'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1097:8: error: '::DuplicateHandle' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1097:8: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1461:29: note:   'testing::internal::DuplicateHandle'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1098:26: error: '::GetCurrentProcess' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1098:26: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1283:28: note:   'testing::internal::GetCurrentProcess'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:43:0:
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1117:3: error: '::SetEvent' has not been declared
./Source/ThirdParty/gtest/src/gtest-death-test.cc:1117:3: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:1398:29: note:   'testing::internal::SetEvent'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:45:0:
./Source/ThirdParty/gtest/src/gtest-port.cc: In constructor 'testing::internal::CapturedStream::CapturedStream(int)':
./Source/ThirdParty/gtest/src/gtest-port.cc:462:5: error: '::GetTempPathA' has not been declared
./Source/ThirdParty/gtest/src/gtest-port.cc:462:5: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:2029:27: note:   'testing::internal::GetTempPathA'
In file included from Source/ThirdParty/gtest/src/gtest-all.cc:45:0:
./Source/ThirdParty/gtest/src/gtest-port.cc:463:26: error: '::GetTempFileNameA' has not been declared
./Source/ThirdParty/gtest/src/gtest-port.cc:463:26: note: suggested alternative:
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:70:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h:198,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:987,
                 from ./Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ./Source/ThirdParty/gtest/include/gtest/gtest.h:57,
                 from Source/ThirdParty/gtest/src/gtest-all.cc:39:
/usr/i686-w64-mingw32/sys-root/mingw/include/winbase.h:2031:26: note:   'testing::internal::GetTempFileNameA'
make[1]: *** [Source/ThirdParty/gtest/src/Libraries_libgtest_la-gtest-all.lo] Błąd 1
make[1]: Opuszczenie katalogu `/home/pawel/src/webkit'
make: *** [all] Błąd 2

It seems to be caused by variable 	Libraries_libgtest_la_CXXFLAGS = -DGTEST_HAS_PTHREAD=1 being explicitly set to true in Source/ThirdParty/gtest/GNUmakefile.am

Is this because of some previous issues?

Comment 1 tuxator 2013-01-31 05:29:21 PST

Created attachment 185760 [details]
first try

Comment 2 Martin Robinson 2013-02-04 11:37:20 PST

Comment on attachment 185760 [details]
first try

I don't think removing pthread support for everyone is the way forward here. Maybe making it conditional makes more sense. This patch is also missing a changelog.

Comment 3 tuxator 2013-02-05 08:58:21 PST

Created attachment 186635 [details]
set stuff conditionall

Comment 4 WebKit Review Bot 2013-02-05 09:00:24 PST

Attachment 186635 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ChangeLog', u'Source/ThirdParty/gtest/GNUmakefile.am']" exit_code: 1
Source/ThirdParty/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 tuxator 2013-02-05 13:12:29 PST

Created attachment 186687 [details]
fix style

Comment 6 WebKit Review Bot 2013-02-05 13:15:01 PST

Attachment 186687 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ChangeLog', u'Source/ThirdParty/gtest/GNUmakefile.am']" exit_code: 1
Source/ThirdParty/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 tuxator 2013-02-05 13:45:22 PST

Created attachment 186695 [details]
Patch

Comment 8 Build Bot 2013-02-05 17:09:26 PST

Comment on attachment 186695 [details]
Patch

Attachment 186695 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16375964

Comment 9 WebKit Review Bot 2013-02-05 18:29:14 PST

Comment on attachment 186695 [details]
Patch

Clearing flags on attachment: 186695

Committed r141959: <http://trac.webkit.org/changeset/141959>

Comment 10 WebKit Review Bot 2013-02-05 18:29:19 PST

All reviewed patches have been landed.  Closing bug.