Bug 108468 - Web Inspector: [Profiles] show launcher view upon deleting last profile type's header
Summary: Web Inspector: [Profiles] show launcher view upon deleting last profile type'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 05:22 PST by Andrey Adaikin
Modified: 2013-01-31 05:44 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2013-01-31 05:23 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-01-31 05:22:10 PST 
We should show launcher view and hide profile type sidebar section upon deleting last profile type's header from the sidebar. Right now we only show launcher view upon deleting the last profile header (of any profile type).

Patch to follow.
Comment 1 Andrey Adaikin 2013-01-31 05:23:09 PST 
Created attachment 185759 [details]
Patch
Comment 2 Yury Semikhatsky 2013-01-31 05:29:10 PST 
Comment on attachment 185759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:612
> +        if (!sidebarParent.children.length) {

Doesn't sidebarParent.children include section headers?
Comment 3 Andrey Adaikin 2013-01-31 05:37:25 PST 
(In reply to comment #2)
> (From update of attachment 185759 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review
> 
> > Source/WebCore/inspector/front-end/ProfilesPanel.js:612
> > +        if (!sidebarParent.children.length) {
> 
> Doesn't sidebarParent.children include section headers?

Looks like it includes only WebInspector.ProfileSidebarTreeElement elements.
Comment 4 WebKit Review Bot 2013-01-31 05:44:15 PST 
Comment on attachment 185759 [details]
Patch

Clearing flags on attachment: 185759

Committed r141409: <http://trac.webkit.org/changeset/141409>
Comment 5 WebKit Review Bot 2013-01-31 05:44:19 PST 
All reviewed patches have been landed.  Closing bug.