RESOLVED FIXED 108468
Web Inspector: [Profiles] show launcher view upon deleting last profile type's header 
https://bugs.webkit.org/show_bug.cgi?id=108468
Summary Web Inspector: [Profiles] show launcher view upon deleting last profile type'...
Andrey Adaikin
Reported 2013-01-31 05:22:10 PST
We should show launcher view and hide profile type sidebar section upon deleting last profile type's header from the sidebar. Right now we only show launcher view upon deleting the last profile header (of any profile type). Patch to follow.
Attachments
Patch (1.80 KB, patch)
2013-01-31 05:23 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2013-01-31 05:23:09 PST
Created attachment 185759 [details] Patch
Yury Semikhatsky
Comment 2 2013-01-31 05:29:10 PST
Comment on attachment 185759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:612 > + if (!sidebarParent.children.length) { Doesn't sidebarParent.children include section headers?
Andrey Adaikin
Comment 3 2013-01-31 05:37:25 PST
(In reply to comment #2) > (From update of attachment 185759 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review > > > Source/WebCore/inspector/front-end/ProfilesPanel.js:612 > > + if (!sidebarParent.children.length) { > > Doesn't sidebarParent.children include section headers? Looks like it includes only WebInspector.ProfileSidebarTreeElement elements.
WebKit Review Bot
Comment 4 2013-01-31 05:44:15 PST
Comment on attachment 185759 [details] Patch Clearing flags on attachment: 185759 Committed r141409: <http://trac.webkit.org/changeset/141409>
WebKit Review Bot
Comment 5 2013-01-31 05:44:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.