Bug 108467 - [chromium] public methods and objects of TestRunner that are only used by the WebTestProxy should be private
Summary: [chromium] public methods and objects of TestRunner that are only used by the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 91308
  Show dependency treegraph
 
Reported: 2013-01-31 05:21 PST by jochen
Modified: 2013-02-04 15:25 PST (History)
6 users (show)

See Also:


Attachments
Patch (63.49 KB, patch)
2013-02-04 04:28 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (43.26 KB, patch)
2013-02-04 05:48 PST, jochen
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (43.33 KB, patch)
2013-02-04 14:15 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-01-31 05:21:13 PST
That includes WebEventSender, WebAccessibilityController, WebTestPlugin, and a bunch of WebTestRunner methods
Comment 1 jochen 2013-02-04 04:28:52 PST
Created attachment 186347 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-04 04:30:42 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 jochen 2013-02-04 05:48:41 PST
Created attachment 186359 [details]
Patch
Comment 4 Adam Barth 2013-02-04 09:34:23 PST
Comment on attachment 186359 [details]
Patch

Usually we prefer one patch per bug.  (These patches are great btw!)
Comment 5 WebKit Review Bot 2013-02-04 11:00:37 PST
Comment on attachment 186347 [details]
Patch

Clearing flags on attachment: 186347

Committed r141785: <http://trac.webkit.org/changeset/141785>
Comment 6 WebKit Review Bot 2013-02-04 11:04:46 PST
Comment on attachment 186359 [details]
Patch

Rejecting attachment 186359 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 186359, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ebTestProxy.cpp.rej
patching file Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp
rm 'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp'
patching file Tools/DumpRenderTree/chromium/TestShell.h
patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp
patching file Tools/DumpRenderTree/chromium/WebViewHost.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16378208
Comment 7 jochen 2013-02-04 14:15:25 PST
Created attachment 186459 [details]
Patch
Comment 8 WebKit Review Bot 2013-02-04 15:25:31 PST
Comment on attachment 186459 [details]
Patch

Clearing flags on attachment: 186459

Committed r141823: <http://trac.webkit.org/changeset/141823>
Comment 9 WebKit Review Bot 2013-02-04 15:25:35 PST
All reviewed patches have been landed.  Closing bug.