Bug 108459 - [WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions
Summary: [WK2][Notifications] Missing early return in populateCopyOfNotificationPermis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 04:24 PST by Claudio Saavedra
Modified: 2013-02-11 11:55 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2013-01-31 04:28 PST, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2013-02-07 01:17 PST, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2013-01-31 04:24:58 PST 
[WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions
Comment 1 Claudio Saavedra 2013-01-31 04:28:40 PST 
Created attachment 185746 [details]
Patch
Comment 2 Claudio Saavedra 2013-01-31 04:30:26 PST 
Jon, could you please have a look at this? I found it while implementing a dummy provider for the GTK+ port. Thank you!
Comment 3 Jon Lee 2013-02-01 11:31:05 PST 
Comment on attachment 185746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185746&action=review

> Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp:96
> +    if (!knownPermissions)

Wouldn't it be more appropriate to move this check before we clear out the permissions? If the client wishes to clear out the permissions, they should provide an empty dictionary instead.
Comment 4 Claudio Saavedra 2013-02-07 01:17:21 PST 
Created attachment 187019 [details]
Patch
Comment 5 Jon Lee 2013-02-07 08:08:00 PST 
Unofficial r=me.
Comment 6 Claudio Saavedra 2013-02-11 06:04:19 PST 
Who to ping to get this reviewed?
Comment 7 Jon Lee 2013-02-11 11:33:31 PST 
Alexey, would you mind r+'ing the patch? It looks good to me.
Comment 8 WebKit Review Bot 2013-02-11 11:55:01 PST 
Comment on attachment 187019 [details]
Patch

Clearing flags on attachment: 187019

Committed r142493: <http://trac.webkit.org/changeset/142493>
Comment 9 WebKit Review Bot 2013-02-11 11:55:05 PST 
All reviewed patches have been landed.  Closing bug.