[WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions
Created attachment 185746 [details]
Jon, could you please have a look at this? I found it while implementing a dummy provider for the GTK+ port. Thank you!
Comment on attachment 185746 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=185746&action=review
> + if (!knownPermissions)
Wouldn't it be more appropriate to move this check before we clear out the permissions? If the client wishes to clear out the permissions, they should provide an empty dictionary instead.
Created attachment 187019 [details]
Who to ping to get this reviewed?
Alexey, would you mind r+'ing the patch? It looks good to me.
Comment on attachment 187019 [details]
Clearing flags on attachment: 187019
Committed r142493: <http://trac.webkit.org/changeset/142493>
All reviewed patches have been landed. Closing bug.