Bug 108458 - [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
Summary: [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStrea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2013-01-31 04:19 PST by Tommy Widenflycht
Modified: 2013-02-01 01:26 PST (History)
9 users (show)

See Also:

Attachments
Patch (70.20 KB, patch)
2013-01-31 04:21 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2013-01-31 04:19:23 PST 
[chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
Comment 1 Tommy Widenflycht 2013-01-31 04:21:19 PST 
Created attachment 185744 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-31 04:24:06 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Tommy Widenflycht 2013-01-31 04:25:18 PST 
Only renames in the patch. I have a corresponding Chromium patch lined up which does the rename there which will be committed as soon as this change is rolled in.

The main reason is that the old names confused other developers who have no idea what a "Descriptor" or "Component" is; and concludes the cleanup of the WebKit names.
Comment 4 Adam Barth 2013-01-31 10:50:06 PST 
Comment on attachment 185744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185744&action=review

> Source/Platform/chromium/public/WebMediaStreamComponent.h:36
> +// The name WebMediaStreamComponent is EXTREMELY DEPRECATED.

EXTREMELY DEPRECATED!!!
Comment 5 WebKit Review Bot 2013-01-31 11:03:05 PST 
Comment on attachment 185744 [details]
Patch

Clearing flags on attachment: 185744

Committed r141444: <http://trac.webkit.org/changeset/141444>
Comment 6 WebKit Review Bot 2013-01-31 11:03:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Tommy Widenflycht 2013-02-01 01:26:20 PST 
(In reply to comment #4)
> (From update of attachment 185744 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185744&action=review
> 
> > Source/Platform/chromium/public/WebMediaStreamComponent.h:36
> > +// The name WebMediaStreamComponent is EXTREMELY DEPRECATED.
> 
> EXTREMELY DEPRECATED!!!

Yes, if someone uses it for new stuff I'll hit them with a rubber chicken ;)

Hopefully the Chromium rename patch goes asap so that I can remove these two compatibility headers later today.