Bug 108457 - [EFL] Disable Web Intents
Summary: [EFL] Disable Web Intents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 04:15 PST by Chris Dumez
Modified: 2013-01-31 10:45 PST (History)
13 users (show)

See Also:

Attachments
Patch (90.91 KB, patch)
2013-01-31 05:49 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (91.09 KB, patch)
2013-01-31 05:54 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-01-31 04:15:47 PST 
The Web Intents spec seems to be pretty much dead and Google is planning to remove support for it from WebKit soon (See mailing list announcement). We should therefore disable Web Intents in EFL port and remove the corresponding code.
Comment 1 Kenneth Rohde Christiansen 2013-01-31 04:38:25 PST 
I totally agree
Comment 2 Gyuyoung Kim 2013-01-31 04:44:25 PST 
AFAIK, Tizen WebKit also disable it because of same reason. CC'ing Kihong.
Comment 3 Chris Dumez 2013-01-31 05:44:17 PST 
(In reply to comment #2)
> AFAIK, Tizen WebKit also disable it because of same reason. CC'ing Kihong.

Yes, it was never enabled for Tizen AFAIK.
Comment 4 Chris Dumez 2013-01-31 05:49:20 PST 
Created attachment 185764 [details]
Patch
Comment 5 Kenneth Rohde Christiansen 2013-01-31 05:51:17 PST 
Comment on attachment 185764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185764&action=review

Nice

> Tools/DumpRenderTree/efl/TestRunnerEfl.cpp:911
> -    DumpRenderTreeSupportEfl::deliverWebIntent(browser->mainFrame(), action, type, data);
> +    notImplemented();

maybe add a comment that it is not intended to be implemented?
Comment 6 Chris Dumez 2013-01-31 05:54:54 PST 
Created attachment 185766 [details]
Patch

Take Kenneth's comments into consideration.
Comment 7 Alexey Proskuryakov 2013-01-31 10:07:43 PST 
Comment on attachment 185766 [details]
Patch

rs=me
Comment 8 WebKit Review Bot 2013-01-31 10:45:16 PST 
Comment on attachment 185766 [details]
Patch

Clearing flags on attachment: 185766

Committed r141439: <http://trac.webkit.org/changeset/141439>
Comment 9 WebKit Review Bot 2013-01-31 10:45:21 PST 
All reviewed patches have been landed.  Closing bug.