RESOLVED FIXED 108456
Web Inspector: Exception in HeapSnapshotView.js 
https://bugs.webkit.org/show_bug.cgi?id=108456
Summary Web Inspector: Exception in HeapSnapshotView.js
Andrey Adaikin
Reported 2013-01-31 04:10:01 PST
Patch to follow. Repro: - Go to Profiles panel and take a Heap Snapshot - Remove the snapshot profile header from the sidebar via context menu - Run another profile, e.g. Capture Canvas Frame - Observe the exception below: Uncaught TypeError: Cannot call method 'fromFile' of undefined InspectorBackend.js:186 InspectorBackendClass.dispatch InspectorBackend.js:186 InspectorFrontendAPI.dispatchMessage InspectorFrontendAPI.js:198 Stack trace: WebInspector.HeapSnapshotView._updateFilterOptions (HeapSnapshotView.js:724) WebInspector.Object.dispatchEventToListeners (Object.js:101) WebInspector.ProfilesPanel.addProfileHeader (ProfilesPanel.js:580) WebInspector.CanvasProfileType._didStartCapturingFrame (CanvasProfileView.js:496) InspectorBackendClass.dispatch (InspectorBackend.js:186) InspectorFrontendAPI.dispatchMessage (InspectorFrontendAPI.js:198)
Attachments
Patch (1.83 KB, patch)
2013-01-31 04:11 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (2.10 KB, patch)
2013-01-31 04:28 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (2.60 KB, patch)
2013-01-31 05:11 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2013-01-31 04:11:17 PST
Created attachment 185742 [details] Patch
Yury Semikhatsky
Comment 2 2013-01-31 04:15:32 PST
Comment on attachment 185742 [details] Patch We should check that the profile being added is a heap snapshot and ignore all other notifications.
Andrey Adaikin
Comment 3 2013-01-31 04:28:46 PST
Created attachment 185747 [details] Patch
Yury Semikhatsky
Comment 4 2013-01-31 04:34:36 PST
Comment on attachment 185747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185747&action=review > Source/WebCore/inspector/front-end/HeapSnapshotView.js:741 > + if (!event.data || event.data.type !== WebInspector.HeapSnapshotProfileType.TypeId) This one will not work for native snapshots with type WebInspector.NativeSnapshotProfileType.TypeId which reuses the same view so we should probably save profile type from the |profile| argument to HeapSnapshotView and compare with it here.
Andrey Adaikin
Comment 5 2013-01-31 05:11:00 PST
Created attachment 185754 [details] Patch
WebKit Review Bot
Comment 6 2013-01-31 06:17:02 PST
Comment on attachment 185754 [details] Patch Clearing flags on attachment: 185754 Committed r141415: <http://trac.webkit.org/changeset/141415>
WebKit Review Bot
Comment 7 2013-01-31 06:17:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.