Bug 108443 - [V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototypeChain()
Summary: [V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototype...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 01:16 PST by Kentaro Hara
Modified: 2013-01-31 17:13 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.06 KB, patch)
2013-01-31 01:17 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-31 01:16:29 PST 
In Dictionary::get(), wrapper->FindInstanceInPrototypeChain(V8XXX::GetTemplate()) is unnecessary for DOM wrappers other than DOMWindow. For wrappers other than DOMWindow, we can simply use V8XXX::HasInstance(wrapper).

I'll clean up the code more by using template in a follow-up patch.
Comment 1 Kentaro Hara 2013-01-31 01:17:54 PST 
Created attachment 185713 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-31 17:13:56 PST 
Comment on attachment 185713 [details]
Patch

Clearing flags on attachment: 185713

Committed r141509: <http://trac.webkit.org/changeset/141509>
Comment 3 WebKit Review Bot 2013-01-31 17:13:59 PST 
All reviewed patches have been landed.  Closing bug.