WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108443
[V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototypeChain()
https://bugs.webkit.org/show_bug.cgi?id=108443
Summary
[V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototype...
Kentaro Hara
Reported
2013-01-31 01:16:29 PST
In Dictionary::get(), wrapper->FindInstanceInPrototypeChain(V8XXX::GetTemplate()) is unnecessary for DOM wrappers other than DOMWindow. For wrappers other than DOMWindow, we can simply use V8XXX::HasInstance(wrapper). I'll clean up the code more by using template in a follow-up patch.
Attachments
Patch
(8.06 KB, patch)
2013-01-31 01:17 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2013-01-31 01:17:54 PST
Created
attachment 185713
[details]
Patch
WebKit Review Bot
Comment 2
2013-01-31 17:13:56 PST
Comment on
attachment 185713
[details]
Patch Clearing flags on attachment: 185713 Committed
r141509
: <
http://trac.webkit.org/changeset/141509
>
WebKit Review Bot
Comment 3
2013-01-31 17:13:59 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug