Bug 108437 - Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
Summary: Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-30 23:56 PST by Eugene Klyuchnikov
Modified: 2013-02-20 20:10 PST (History)
10 users (show)

See Also:

Attachments
Patch (24.35 KB, patch)
2013-01-31 00:23 PST, Eugene Klyuchnikov 		pfeldman: review+
Details | Formatted Diff | Diff
Patch (24.40 KB, patch)
2013-01-31 06:16 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-01-30 23:56:07 PST 
CPU Profile code has obsolete inline-comments to clarify types.
Currently we use JSDocs to specify types.

Also applied some minor refactorings.
Comment 1 Eugene Klyuchnikov 2013-01-31 00:23:44 PST 
Created attachment 185701 [details]
Patch
Comment 2 Pavel Feldman 2013-01-31 03:50:00 PST 
Comment on attachment 185701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185701&action=review

> Source/WebCore/inspector/front-end/BottomUpProfileDataGridTree.js:60
> +     *

Extra blank line we don't need.
Comment 3 Eugene Klyuchnikov 2013-01-31 06:10:47 PST 
Comment on attachment 185701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185701&action=review

>> Source/WebCore/inspector/front-end/BottomUpProfileDataGridTree.js:60
>> +     *
> 
> Extra blank line we don't need.

Fixed.
Comment 4 Eugene Klyuchnikov 2013-01-31 06:16:38 PST 
Created attachment 185768 [details]
Patch
Comment 5 Andrey Kosyakov 2013-02-04 05:57:59 PST 
Committed r141764: <http://trac.webkit.org/changeset/141764>