RESOLVED FIXED 108437
Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs. 
https://bugs.webkit.org/show_bug.cgi?id=108437
Summary Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
Eugene Klyuchnikov
Reported 2013-01-30 23:56:07 PST
CPU Profile code has obsolete inline-comments to clarify types. Currently we use JSDocs to specify types. Also applied some minor refactorings.
Attachments
Patch (24.35 KB, patch)
2013-01-31 00:23 PST, Eugene Klyuchnikov 		pfeldman: review+
DetailsFormatted DiffDiff
Patch (24.40 KB, patch)
2013-01-31 06:16 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-01-31 00:23:44 PST
Created attachment 185701 [details] Patch
Pavel Feldman
Comment 2 2013-01-31 03:50:00 PST
Comment on attachment 185701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185701&action=review > Source/WebCore/inspector/front-end/BottomUpProfileDataGridTree.js:60 > + * Extra blank line we don't need.
Eugene Klyuchnikov
Comment 3 2013-01-31 06:10:47 PST
Comment on attachment 185701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185701&action=review >> Source/WebCore/inspector/front-end/BottomUpProfileDataGridTree.js:60 >> + * > > Extra blank line we don't need. Fixed.
Eugene Klyuchnikov
Comment 4 2013-01-31 06:16:38 PST
Created attachment 185768 [details] Patch
Andrey Kosyakov
Comment 5 2013-02-04 05:57:59 PST
Committed r141764: <http://trac.webkit.org/changeset/141764>
Note You need to log in before you can comment on or make changes to this bug.