RESOLVED FIXED 108436
[V8] Trace not only major DOM GCs but also minor DOM GCs 
https://bugs.webkit.org/show_bug.cgi?id=108436
Summary [V8] Trace not only major DOM GCs but also minor DOM GCs
Kentaro Hara
Reported 2013-01-30 23:40:39 PST
Currently only major DOM GCs are traced. We should also trace minor DOM GCs.
Attachments
Patch (1.71 KB, patch)
2013-01-30 23:41 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-01-30 23:41:44 PST
Created attachment 185688 [details] Patch
Adam Barth
Comment 2 2013-01-31 00:04:06 PST
Comment on attachment 185688 [details] Patch TRACE_EVENT_BEGIN0 runs in release, right? Does this impact the performance of minor GC?
Kentaro Hara
Comment 3 2013-01-31 00:07:50 PST
(In reply to comment #2) > (From update of attachment 185688 [details]) > TRACE_EVENT_BEGIN0 runs in release, right? Does this impact the performance of minor GC? Yes, it runs in release. But when I measured the overhead of TRACE_EVENT(), it was less than 10 ns, which is ignorable for minor GCs.
Adam Barth
Comment 4 2013-01-31 00:11:18 PST
Thanks!
WebKit Review Bot
Comment 5 2013-01-31 00:54:31 PST
Comment on attachment 185688 [details] Patch Clearing flags on attachment: 185688 Committed r141390: <http://trac.webkit.org/changeset/141390>
WebKit Review Bot
Comment 6 2013-01-31 00:54:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.