Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent In a follow-up patch I will implement a 'deltaMode' attribute.
Created attachment 185685 [details] Patch
Comment on attachment 185685 [details] Patch Attachment 185685 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16283030
Comment on attachment 185685 [details] Patch Attachment 185685 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16271063
Comment on attachment 185685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185685&action=review rs=me but please fix the build before you land it. > Source/WebCore/dom/WheelEvent.cpp:56 > + DeltaMode deltaMode, PassRefPtr<AbstractView> view, > + const IntPoint& screenLocation, const IntPoint& pageLocation, > + bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, > + bool directionInvertedFromDevice) It seems like we can fit all of this in two lines if not one?
Created attachment 185704 [details] patch for landing
(In reply to comment #4) > (From update of attachment 185685 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185685&action=review > > rs=me but please fix the build before you land it. Thanks! Will do. > It seems like we can fit all of this in two lines if not one? Done.
Comment on attachment 185704 [details] patch for landing Clearing flags on attachment: 185704 Committed r141394: <http://trac.webkit.org/changeset/141394>
All reviewed patches have been landed. Closing bug.