Bug 108408 - [chromium] Build webkit with enable_web_intents set to 0.
Summary: [chromium] Build webkit with enable_web_intents set to 0.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on: 108421
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-30 17:30 PST by Nico Weber
Modified: 2013-02-01 11:15 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2013-01-30 17:31 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (10.89 KB, patch)
2013-01-31 12:06 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (10.98 KB, patch)
2013-01-31 14:18 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2013-01-30 17:30:09 PST 
[chromium] Build webkit with enable_web_intents set to 0.
Comment 1 Nico Weber 2013-01-30 17:31:34 PST 
Created attachment 185634 [details]
Patch
Comment 2 Kentaro Hara 2013-01-30 17:40:46 PST 
Comment on attachment 185634 [details]
Patch

LGTM
Comment 3 Kentaro Hara 2013-01-30 17:55:20 PST 
(Although I think this is not controversial as this is just a chromium-only change, you might want to wait to cq+ the patch for one day to give folks a chance to comment on the webkit-dev@ thread.)
Comment 4 Adam Barth 2013-01-30 17:57:28 PST 
Comment on attachment 185634 [details]
Patch

I don't think there's a need to wait to fix the build with ENABLE(WEB_INTENTS) off.
Comment 5 WebKit Review Bot 2013-01-30 18:19:08 PST 
Comment on attachment 185634 [details]
Patch

Clearing flags on attachment: 185634

Committed r141358: <http://trac.webkit.org/changeset/141358>
Comment 6 WebKit Review Bot 2013-01-30 18:19:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2013-01-30 20:48:04 PST 
Re-opened since this is blocked by bug 108421
Comment 8 Nico Weber 2013-01-31 12:06:41 PST 
Created attachment 185833 [details]
Patch
Comment 9 Nico Weber 2013-01-31 12:07:03 PST 
Comment on attachment 185833 [details]
Patch

(still testing)
Comment 10 Nico Weber 2013-01-31 14:18:31 PST 
Created attachment 185862 [details]
Patch
Comment 11 Nico Weber 2013-01-31 14:19:26 PST 
Ok, ptal. I checked that this now builds on android (with the dependent patch) and OS X. I won't land this before chromium deps have the dependency.
Comment 12 Peter Beverloo (cr-android ews) 2013-01-31 16:36:34 PST 
Comment on attachment 185862 [details]
Patch

Attachment 185862 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16300065
Comment 13 Peter Beverloo (cr-android ews) 2013-01-31 17:44:24 PST 
Comment on attachment 185862 [details]
Patch

Attachment 185862 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16305111
Comment 14 Nico Weber 2013-02-01 10:21:46 PST 
Comment on attachment 185862 [details]
Patch

After r141537, this should hopefully build on android.
Comment 15 WebKit Review Bot 2013-02-01 11:15:37 PST 
Comment on attachment 185862 [details]
Patch

Clearing flags on attachment: 185862

Committed r141614: <http://trac.webkit.org/changeset/141614>
Comment 16 WebKit Review Bot 2013-02-01 11:15:42 PST 
All reviewed patches have been landed.  Closing bug.