Bug 108407 - Add a call to the page UI client to determine if a plug-in should load
Summary: Add a call to the page UI client to determine if a plug-in should load
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Weinstein
Keywords: InRadar
Depends on:
Reported: 2013-01-30 17:23 PST by Brian Weinstein
Modified: 2013-01-31 14:20 PST (History)
4 users (show)

See Also:

Patch (15.60 KB, patch)
2013-01-31 13:41 PST, Brian Weinstein
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2013-01-30 17:23:35 PST
Add a call to the page UI client to determine if a plug-in should load

Comment 1 Brian Weinstein 2013-01-31 13:41:56 PST
Created attachment 185851 [details]
Comment 2 WebKit Review Bot 2013-01-31 13:43:50 PST
Attachment 185851 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/WebProcessProxy.cpp', u'Source/WebKit2/UIProcess/WebProcessProxy.h', u'Source/WebKit2/UIProcess/WebProcessProxy.messages.in', u'Source/WebKit2/UIProcess/WebUIClient.cpp', u'Source/WebKit2/UIProcess/WebUIClient.h', u'Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Tools/ChangeLog', u'Tools/MiniBrowser/mac/WK2BrowserWindowController.m', u'Tools/WebKitTestRunner/TestController.cpp']" exit_code: 1
Source/WebKit2/WebProcess/WebPage/WebPage.h:575:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/WebProcess/WebPage/WebPage.cpp:505:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 13 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brian Weinstein 2013-01-31 14:20:07 PST
Landed in r141486.