RESOLVED FIXED 108395
Provide a sensible default architecture when building on iOS SDKs 
https://bugs.webkit.org/show_bug.cgi?id=108395
Summary Provide a sensible default architecture when building on iOS SDKs
David Farler
Reported 2013-01-30 15:54:25 PST
The current default architecture for Apple ports is x86_64 - we should default to armv7 and i386 for iphoneos and iphonesimulator SDKs respectively.
Attachments
Patch (3.43 KB, patch)
2013-01-30 21:27 PST, David Farler 		no flags
DetailsFormatted DiffDiff
Patch (3.49 KB, patch)
2013-01-31 15:03 PST, David Farler 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2013-01-31 20:12 PST, David Farler 		no flags
DetailsFormatted DiffDiff
Patch (1.34 KB, patch)
2013-02-01 12:49 PST, David Farler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
David Farler
Comment 1 2013-01-30 21:27:08 PST
Created attachment 185673 [details] Patch
David Farler
Comment 2 2013-01-31 11:00:58 PST
Comment on attachment 185673 [details] Patch For review.
Joseph Pecoraro
Comment 3 2013-01-31 14:52:08 PST
Comment on attachment 185673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185673&action=review r=me, but consider cleaning up the line in XcodeOptions. > Tools/Scripts/webkitdirs.pm:556 > + return (@baseProductDirOption, "-configuration", $configuration, ($architecture ? "ARCHS=$architecture" : ()),($xcodeSDK ? "SDKROOT=$xcodeSDK" : ()), argumentsForXcode()); It would be nice to pull out the ARCHS and SDKROOT ternaries into their own lines to make this line to enhance readability.
David Farler
Comment 4 2013-01-31 15:03:18 PST
Created attachment 185874 [details] Patch
Joseph Pecoraro
Comment 5 2013-01-31 15:08:21 PST
Comment on attachment 185874 [details] Patch r=me
WebKit Review Bot
Comment 6 2013-01-31 17:35:37 PST
Comment on attachment 185874 [details] Patch Clearing flags on attachment: 185874 Committed r141515: <http://trac.webkit.org/changeset/141515>
WebKit Review Bot
Comment 7 2013-01-31 17:35:40 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 8 2013-01-31 17:36:38 PST
Comment on attachment 185874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185874&action=review > Tools/Scripts/webkitdirs.pm:322 > + if (not defined $xcodeSDK or $xcodeSDK =~ /\/|macosx/) { I would have made this a bit more exclusive; the regex above matches any string with "/" or "macosx" in it: if (not defined $xcodeSDK or $xcodeSDK eq "/" or $xcodeSDK =~ /^macosx/) { > Tools/Scripts/webkitdirs.pm:326 > + } elsif ($xcodeSDK =~ /iphonesimulator/) { Suggest: /^iphonesimulator/ > Tools/Scripts/webkitdirs.pm:328 > + } elsif ($xcodeSDK =~ /iphoneos/) { Suggest: /^iphoneos/
David Farler
Comment 9 2013-01-31 20:08:41 PST
Quick regex cleanup.
David Farler
Comment 10 2013-01-31 20:12:48 PST
Created attachment 185921 [details] Patch
WebKit Review Bot
Comment 11 2013-01-31 21:03:09 PST
Comment on attachment 185921 [details] Patch Clearing flags on attachment: 185921 Committed r141534: <http://trac.webkit.org/changeset/141534>
WebKit Review Bot
Comment 12 2013-01-31 21:03:14 PST
All reviewed patches have been landed. Closing bug.
David Farler
Comment 13 2013-02-01 12:49:38 PST
Reopening to attach new patch.
David Farler
Comment 14 2013-02-01 12:49:40 PST
Created attachment 186111 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.