The current default architecture for Apple ports is x86_64 - we should default to armv7 and i386 for iphoneos and iphonesimulator SDKs respectively.
Created attachment 185673 [details] Patch
Comment on attachment 185673 [details] Patch For review.
Comment on attachment 185673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185673&action=review r=me, but consider cleaning up the line in XcodeOptions. > Tools/Scripts/webkitdirs.pm:556 > + return (@baseProductDirOption, "-configuration", $configuration, ($architecture ? "ARCHS=$architecture" : ()),($xcodeSDK ? "SDKROOT=$xcodeSDK" : ()), argumentsForXcode()); It would be nice to pull out the ARCHS and SDKROOT ternaries into their own lines to make this line to enhance readability.
Created attachment 185874 [details] Patch
Comment on attachment 185874 [details] Patch r=me
Comment on attachment 185874 [details] Patch Clearing flags on attachment: 185874 Committed r141515: <http://trac.webkit.org/changeset/141515>
All reviewed patches have been landed. Closing bug.
Comment on attachment 185874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185874&action=review > Tools/Scripts/webkitdirs.pm:322 > + if (not defined $xcodeSDK or $xcodeSDK =~ /\/|macosx/) { I would have made this a bit more exclusive; the regex above matches any string with "/" or "macosx" in it: if (not defined $xcodeSDK or $xcodeSDK eq "/" or $xcodeSDK =~ /^macosx/) { > Tools/Scripts/webkitdirs.pm:326 > + } elsif ($xcodeSDK =~ /iphonesimulator/) { Suggest: /^iphonesimulator/ > Tools/Scripts/webkitdirs.pm:328 > + } elsif ($xcodeSDK =~ /iphoneos/) { Suggest: /^iphoneos/
Quick regex cleanup.
Created attachment 185921 [details] Patch
Comment on attachment 185921 [details] Patch Clearing flags on attachment: 185921 Committed r141534: <http://trac.webkit.org/changeset/141534>
Reopening to attach new patch.
Created attachment 186111 [details] Patch