Bug 108393 - [BlackBerry] Bing Images viewport causes layout "fun"
Summary: [BlackBerry] Bing Images viewport causes layout "fun"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jacky Jiang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-30 15:41 PST by Jacky Jiang
Modified: 2013-01-31 14:00 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.66 KB, patch)
2013-01-30 16:44 PST, Jacky Jiang 		no flags Details | Formatted Diff | Diff
Patch (9.83 KB, patch)
2013-01-31 13:03 PST, Jacky Jiang 		yong.li.webkit: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2013-01-30 15:41:24 PST 
PR: 277855
Comment 1 Jacky Jiang 2013-01-30 16:44:51 PST 
Created attachment 185620 [details]
Patch
Comment 2 Jacky Jiang 2013-01-31 13:03:47 PST 
Created attachment 185844 [details]
Patch
Comment 3 Yong Li 2013-01-31 13:18:51 PST 
Comment on attachment 185844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185844&action=review

> Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:51
> +static FloatRect toUserSpace(FloatRect rect, Widget* widget)

minor: 1. This function can be inline. 2. the null check for widget can be moved to this function
Comment 4 Jacky Jiang 2013-01-31 13:32:58 PST 
(In reply to comment #3)
> (From update of attachment 185844 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185844&action=review
> 
> > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:51
> > +static FloatRect toUserSpace(FloatRect rect, Widget* widget)
> 
> minor: 1. This function can be inline. 2. the null check for widget can be moved to this function

That function is just to be consistent with chromium port.  Discussed with Yong, I can push it and may clean it in the future if we indeed want to do that.
Comment 5 Jacky Jiang 2013-01-31 14:00:30 PST 
Committed r141481: <http://trac.webkit.org/changeset/141481>