Bug 108387 - [BlackBerry] proxy credentials can be overwritten
Summary: [BlackBerry] proxy credentials can be overwritten
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joe Mason
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-30 14:48 PST by Joe Mason
Modified: 2013-01-30 16:04 PST (History)
5 users (show)

See Also:

Attachments
workaround (3.05 KB, patch)
2013-01-30 14:50 PST, Joe Mason 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2013-01-30 14:48:36 PST 
There is a code path that can cause NetworkJob::storeCredentials to be called with empty credentials, causing the existing credentials to be overwritten even though authentication succeeded.  (This happens when the proxy credentials are read from the system settings in the network layer rather than in webkit.) Internal PR 287791 has been filed to investigate why this happens; in the meantime, ignore empty credentials as a workaround.
Comment 1 Joe Mason 2013-01-30 14:50:22 PST 
Created attachment 185585 [details]
workaround
Comment 2 Yong Li 2013-01-30 15:03:19 PST 
Comment on attachment 185585 [details]
workaround

r+ based on Leo's review
Comment 3 WebKit Review Bot 2013-01-30 16:04:40 PST 
Comment on attachment 185585 [details]
workaround

Clearing flags on attachment: 185585

Committed r141336: <http://trac.webkit.org/changeset/141336>
Comment 4 WebKit Review Bot 2013-01-30 16:04:43 PST 
All reviewed patches have been landed.  Closing bug.