WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108387
[BlackBerry] proxy credentials can be overwritten
https://bugs.webkit.org/show_bug.cgi?id=108387
Summary
[BlackBerry] proxy credentials can be overwritten
Joe Mason
Reported
2013-01-30 14:48:36 PST
There is a code path that can cause NetworkJob::storeCredentials to be called with empty credentials, causing the existing credentials to be overwritten even though authentication succeeded. (This happens when the proxy credentials are read from the system settings in the network layer rather than in webkit.) Internal PR 287791 has been filed to investigate why this happens; in the meantime, ignore empty credentials as a workaround.
Attachments
workaround
(3.05 KB, patch)
2013-01-30 14:50 PST
,
Joe Mason
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joe Mason
Comment 1
2013-01-30 14:50:22 PST
Created
attachment 185585
[details]
workaround
Yong Li
Comment 2
2013-01-30 15:03:19 PST
Comment on
attachment 185585
[details]
workaround r+ based on Leo's review
WebKit Review Bot
Comment 3
2013-01-30 16:04:40 PST
Comment on
attachment 185585
[details]
workaround Clearing flags on attachment: 185585 Committed
r141336
: <
http://trac.webkit.org/changeset/141336
>
WebKit Review Bot
Comment 4
2013-01-30 16:04:43 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug