Bug 108381 - [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
Summary: [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-30 14:11 PST by Levi Weintraub
Modified: 2013-01-30 18:16 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2013-01-30 14:17 PST, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Patch (8.37 KB, patch)
2013-01-30 17:14 PST, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2013-01-30 14:11:59 PST 
Previously, WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested to receive touch events. When it's destructed, it only calls didRemoveTouchEventHandler once, leading to an imbalance. The fix here is to only call didAddTouchEventHandler once if touch events are requested.
Comment 1 Levi Weintraub 2013-01-30 14:17:07 PST 
Created attachment 185568 [details]
Patch
Comment 2 James Robinson 2013-01-30 14:22:07 PST 
Comment on attachment 185568 [details]
Patch

We have a test plugin in Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin that can hit this API, any chance of a test?
Comment 3 Levi Weintraub 2013-01-30 14:23:43 PST 
Let me take a look!
Comment 4 Levi Weintraub 2013-01-30 17:14:05 PST 
Created attachment 185630 [details]
Patch
Comment 5 Levi Weintraub 2013-01-30 17:26:20 PST 
Comment on attachment 185630 [details]
Patch

Ty.
Comment 6 WebKit Review Bot 2013-01-30 18:16:35 PST 
Comment on attachment 185630 [details]
Patch

Clearing flags on attachment: 185630

Committed r141357: <http://trac.webkit.org/changeset/141357>
Comment 7 WebKit Review Bot 2013-01-30 18:16:38 PST 
All reviewed patches have been landed.  Closing bug.