Bug 108362 – Add a concept of dashboard parameters that invalidate others

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Julie Parent]

Add a concept of dashboard parameters that invalidate others

[Julie Parent]

Created attachment 185529 [details]
Patch

[Dirk Pranke]

Comment on attachment 185529 [details]
Patch

I'm not sure I understand what it means for one parameter to invalidate another. Does that mean the parameters are mutually exclusive? I take it that, for example, if someone specifies testType=, you want group= to be reset to the default? So you can't actually specify both meaningfully? Is that the same thing as saying that one parameter overrides another?

[Julie Parent]

There are parameters that depend on each other.  So, for example, the list of builders available depends on the group.

Imagine I have the flakiness dashboard loaded with the group set to ToT - chromium.org and the builder set to WebKit Linux: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&builder=WebKit%20Linux

Then, I switch the group to ToT webkit.org.  Webkit Linux is no longer a valid builder for that configuration.  Currently, the dashboard will select a new default but the query string keeps the old one, so now there is a mismatch between what is selected and what is in the url (and is incorrect in other parts of the code too).  Sometimes js errors hit due to these mismatches as well.

[Dirk Pranke]

Comment on attachment 185529 [details]
Patch

Okay. I understand what you're getting at, I think. I think the naming is a bit confusing, but I don't have any better ideas.

[WebKit Review Bot]

Comment on attachment 185529 [details]
Patch

Clearing flags on attachment: 185529

Committed r141355: <http://trac.webkit.org/changeset/141355>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.