This is in preparation for testing the patch for bug 70634. We need to test if a composited layer is marked opaque/not. The suggested way to do it is to print out GraphicsLayer::m_contentsOpaque if it has non-default value. Since this might change the text output of some existing layout tests, I think this should be landed separately.
Created attachment 185535 [details] Patch
smfr: I was under the impression that we do not dump the root layer to avoid platform differences. But that is not true. Locally I see several (112) compositing layout tests failures due to the text difference. Which do you prefer - rebaseline those tests or not print m_contentsOpaque for root layer.
Comment on attachment 185535 [details] Patch Attachment 185535 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16183859 New failing tests: compositing/geometry/bounds-clipped-composited-child.html compositing/geometry/clip.html compositing/geometry/limit-layer-bounds-positioned.html compositing/geometry/bounds-ignores-hidden-composited-descendant.html compositing/geometry/bounds-ignores-hidden.html compositing/geometry/limit-layer-bounds-clipping-ancestor.html compositing/backing/no-backing-for-clip-overlap.html compositing/filters/sw-shadow-overlaps-hw-shadow.html compositing/bounds-in-flipped-writing-mode.html compositing/geometry/fixed-position-composited-switch.html compositing/filters/sw-shadow-overlaps-hw-layer.html compositing/geometry/foreground-layer.html compositing/absolute-inside-out-of-view-fixed.html compositing/geometry/limit-layer-bounds-overflow-root.html compositing/filters/sw-layer-overlaps-hw-shadow.html compositing/geometry/limit-layer-bounds-fixed-positioned.html compositing/geometry/layer-due-to-layer-children-deep-switch.html compositing/geometry/ancestor-overflow-change.html compositing/geometry/limit-layer-bounds-positioned-transition.html compositing/geometry/clip-inside.html compositing/geometry/layer-due-to-layer-children-switch.html compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html compositing/columns/composited-in-paginated.html compositing/geometry/bounds-ignores-hidden-dynamic.html compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html compositing/geometry/flipped-writing-mode.html compositing/overflow-trumps-transform-style.html compositing/backing/no-backing-for-clip.html compositing/backing/no-backing-for-perspective.html compositing/clip-child-by-non-stacking-ancestor.html
We start dumping at the renderview's layer (IIRC) which is the one that will be opaque. So I think rebaselining is better.
Comment on attachment 185535 [details] Patch Attachment 185535 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16218725 New failing tests: compositing/geometry/bounds-clipped-composited-child.html compositing/geometry/clip.html compositing/iframes/enter-compositing-iframe.html compositing/geometry/bounds-ignores-hidden-composited-descendant.html compositing/geometry/bounds-ignores-hidden.html compositing/iframes/connect-compositing-iframe-delayed.html compositing/backing/no-backing-for-clip-overlap.html compositing/filters/sw-shadow-overlaps-hw-shadow.html compositing/bounds-in-flipped-writing-mode.html compositing/columns/composited-in-paginated.html compositing/iframes/become-overlapped-iframe.html compositing/filters/sw-shadow-overlaps-hw-layer.html compositing/iframes/connect-compositing-iframe3.html compositing/absolute-inside-out-of-view-fixed.html compositing/tiled-layers-hidpi.html compositing/filters/sw-layer-overlaps-hw-shadow.html compositing/geometry/ancestor-overflow-change.html compositing/geometry/clip-inside.html compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html compositing/iframes/connect-compositing-iframe.html compositing/iframes/become-composited-nested-iframes.html compositing/geometry/bounds-ignores-hidden-dynamic.html compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html compositing/iframes/composited-parent-iframe.html compositing/overflow-trumps-transform-style.html compositing/backing/no-backing-for-clip.html compositing/iframes/connect-compositing-iframe2.html compositing/backing/no-backing-for-perspective.html compositing/clip-child-by-non-stacking-ancestor.html
Comment on attachment 185535 [details] Patch Attachment 185535 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16252009 New failing tests: compositing/geometry/bounds-clipped-composited-child.html compositing/geometry/clip.html compositing/absolute-inside-out-of-view-fixed.html compositing/geometry/bounds-ignores-hidden.html compositing/iframes/connect-compositing-iframe-delayed.html compositing/images/clip-on-directly-composited-image.html compositing/backing/no-backing-for-clip-overlap.html compositing/filters/sw-shadow-overlaps-hw-shadow.html compositing/bounds-in-flipped-writing-mode.html compositing/columns/composited-in-paginated.html compositing/iframes/become-overlapped-iframe.html compositing/filters/sw-shadow-overlaps-hw-layer.html compositing/iframes/connect-compositing-iframe3.html compositing/geometry/bounds-ignores-hidden-composited-descendant.html compositing/iframes/enter-compositing-iframe.html compositing/filters/sw-layer-overlaps-hw-shadow.html compositing/geometry/ancestor-overflow-change.html compositing/geometry/clip-inside.html compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html compositing/iframes/connect-compositing-iframe.html compositing/iframes/become-composited-nested-iframes.html compositing/geometry/bounds-ignores-hidden-dynamic.html compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html compositing/iframes/composited-parent-iframe.html compositing/overflow-trumps-transform-style.html compositing/backing/no-backing-for-clip.html compositing/iframes/connect-compositing-iframe2.html compositing/backing/no-backing-for-perspective.html compositing/layer-creation/animation-overlap-with-children.html compositing/clip-child-by-non-stacking-ancestor.html
Comment on attachment 185535 [details] Patch Attachment 185535 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16283009
Created attachment 185968 [details] updated text baselines using a script - checking if the bots like it
Comment on attachment 185968 [details] updated text baselines using a script - checking if the bots like it Attachment 185968 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16303496 New failing tests: compositing/visible-rect/iframe-no-layers.html compositing/visibility/visibility-image-layers-dynamic.html
Comment on attachment 185968 [details] updated text baselines using a script - checking if the bots like it Attachment 185968 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16301634 New failing tests: platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic.html compositing/visibility/visibility-image-layers-dynamic.html platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic.html
Comment on attachment 185968 [details] updated text baselines using a script - checking if the bots like it Attachment 185968 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16303577 New failing tests: platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic.html compositing/visibility/visibility-image-layers-dynamic.html platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic.html
Comment on attachment 185968 [details] updated text baselines using a script - checking if the bots like it Attachment 185968 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16307806 New failing tests: platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html compositing/visibility/visibility-image-layers-dynamic.html platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background.html platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed.html platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer.html platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background.html platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned.html compositing/visible-rect/iframe-no-layers.html
Committed r141634: <http://trac.webkit.org/changeset/141634>