Bug 108346 - Web Inspector: relax goto file matching again.
Summary: Web Inspector: relax goto file matching again.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
: 93166 (view as bug list)
Depends on:
Reported: 2013-01-30 07:55 PST by Pavel Feldman
Modified: 2013-02-04 14:38 PST (History)
9 users (show)

See Also:

Patch (5.39 KB, patch)
2013-01-30 07:59 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (17.81 KB, patch)
2013-02-01 05:46 PST, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff
screenshot of FilteredItemSelectionDialog (46.38 KB, image/png)
2013-02-04 14:38 PST, johnjbarton
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2013-01-30 07:55:19 PST
This change brings back behavior introduced in r116244.
Comment 1 Pavel Feldman 2013-01-30 07:59:17 PST
Created attachment 185506 [details]
Comment 2 Vsevolod Vlasov 2013-02-01 01:50:11 PST
Comment on attachment 185506 [details]

As discussed offline this could still be improved. Clearing r? for now, see  https://bugs.webkit.org/show_bug.cgi?id=93166 also for a previous discussion about that.
Comment 3 Vsevolod Vlasov 2013-02-01 01:51:29 PST
*** Bug 93166 has been marked as a duplicate of this bug. ***
Comment 4 Pavel Feldman 2013-02-01 05:46:20 PST
Created attachment 186025 [details]
Comment 5 Vsevolod Vlasov 2013-02-01 07:26:15 PST
Comment on attachment 186025 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=186025&action=review

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:247
> +                score += ignoreCase ? 20 : 10;

10 : 20
Comment 6 Pavel Feldman 2013-02-01 07:48:09 PST
Committed r141594: <http://trac.webkit.org/changeset/141594>
Comment 7 johnjbarton 2013-02-01 09:00:07 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=186025&action=review

> LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt:12
> +Output:["abc","acB"]

For Case sensitive matching I would expect 
  Output: ["acB"]
since abc does not match aB with case

> LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt:32
> +Output:["fooBarBaz","foo_bar_baz","foobarBaz","foobarbaz","FooBarBaz","Foo_Bar_Baz","a fooBarBaz","aFooBarBaz","afooBarBaz"]

For Camel case matching, I would not expect fBaB to match foo_bar_baz nor foobarBaz, foobarbaz FooBarBaz etc. To me the output should be
  Output:["fooBarBaz", "a fooBarBaz"]
Comment 8 johnjbarton 2013-02-04 14:38:44 PST
Created attachment 186462 [details]
screenshot of FilteredItemSelectionDialog

Here is an example of how Bug 93166 isn't really a duplicate of this bug.

The user types "all", the default selection ignores >all<InFile.html and >All<ExpresionsQuery.js but instead picks AdvancedSearchController.js.

Relaxed matching is great because it helps the user explore the space quickly based on the character they know. Shortest match compliments this by defaulting to the most constrained match among all the relaxed matches.