WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108326
Add default implementation for KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=108326
Summary
Add default implementation for KURL::fileSystemPath()
Patrick R. Gansterer
Reported
2013-01-30 04:39:05 PST
Add default implementation for KURL::fileSystemPath()
Attachments
Patch
(10.05 KB, patch)
2013-01-30 04:45 PST
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Patch
(10.86 KB, patch)
2013-01-30 23:51 PST
,
Patrick R. Gansterer
benjamin
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2013-01-30 04:45:40 PST
Created
attachment 185467
[details]
Patch
Alexey Proskuryakov
Comment 2
2013-01-30 11:31:06 PST
Comment on
attachment 185467
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=185467&action=review
> Source/WebCore/platform/KURL.cpp:654 > + return path();
One common case where this would fail is for any path that has percent-encoded characters. I understand that this is just refactoring that doesn't change behavior for worse, however code in cross-platform files has a higher expectation of correctness than port-specific code.
Patrick R. Gansterer
Comment 3
2013-01-30 23:51:02 PST
Created
attachment 185692
[details]
Patch
WebKit Review Bot
Comment 4
2013-01-31 03:29:16 PST
Comment on
attachment 185692
[details]
Patch
Attachment 185692
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/16266160
New failing tests: fast/frames/parser-append-subframe-count.html
Benjamin Poulain
Comment 5
2013-04-07 14:45:17 PDT
Comment on
attachment 185692
[details]
Patch I am unhappy this adds more platform stuff in KURL. This is a nice improvement nonetheless.
Patrick R. Gansterer
Comment 6
2013-04-07 15:17:35 PDT
Committed
r147883
: <
http://trac.webkit.org/changeset/147883
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug