Bug 108326 - Add default implementation for KURL::fileSystemPath()
Summary: Add default implementation for KURL::fileSystemPath()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
Depends on:
Reported: 2013-01-30 04:39 PST by Patrick R. Gansterer
Modified: 2013-04-07 15:17 PDT (History)
8 users (show)

See Also:

Patch (10.05 KB, patch)
2013-01-30 04:45 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (10.86 KB, patch)
2013-01-30 23:51 PST, Patrick R. Gansterer
benjamin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-01-30 04:39:05 PST
Add default implementation for KURL::fileSystemPath()
Comment 1 Patrick R. Gansterer 2013-01-30 04:45:40 PST
Created attachment 185467 [details]
Comment 2 Alexey Proskuryakov 2013-01-30 11:31:06 PST
Comment on attachment 185467 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=185467&action=review

> Source/WebCore/platform/KURL.cpp:654
> +    return path();

One common case where this would fail is for any path that has percent-encoded characters.

I understand that this is just refactoring that doesn't change behavior for worse, however code in cross-platform files has a higher expectation of correctness than port-specific code.
Comment 3 Patrick R. Gansterer 2013-01-30 23:51:02 PST
Created attachment 185692 [details]
Comment 4 WebKit Review Bot 2013-01-31 03:29:16 PST
Comment on attachment 185692 [details]

Attachment 185692 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16266160

New failing tests:
Comment 5 Benjamin Poulain 2013-04-07 14:45:17 PDT
Comment on attachment 185692 [details]

I am unhappy this adds more platform stuff in KURL.
This is a nice improvement nonetheless.
Comment 6 Patrick R. Gansterer 2013-04-07 15:17:35 PDT
Committed r147883: <http://trac.webkit.org/changeset/147883>