Bug 108325 - [Qt][Win] r141177 broke the build
Summary: [Qt][Win] r141177 broke the build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108244
  Show dependency tree / graph
 
Reported: 2013-01-30 04:13 PST by Zoltan Arvai
Modified: 2013-01-30 11:14 PST (History)
7 users (show)

See Also:

Attachments
build fix (1.84 KB, patch)
2013-01-30 07:14 PST, Zoltan Arvai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Arvai 2013-01-30 04:13:45 PST 
First r141174 broke the build, but r141203 fixed some of the issues. 
After that r141177 broke Win build by removing MessageID methods.

Current build log:

C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\win\ConnectionWin.cpp(176) : error C2039: 'fromInt' : is not a member of 'CoreIPC::MessageID'
        c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\platform\coreipc\MessageID.h(162) : see declaration of 'CoreIPC::MessageID'
C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\win\ConnectionWin.cpp(176) : error C3861: 'fromInt': identifier not found
C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\win\ConnectionWin.cpp(291) : error C2039: 'toInt' : is not a member of 'CoreIPC::MessageID'
        c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\platform\coreipc\MessageID.h(162) : see declaration of 'CoreIPC::MessageID'
Comment 1 Zoltan Arvai 2013-01-30 07:14:10 PST 
Created attachment 185500 [details]
build fix

This build fix created based on the patch in https://bugs.webkit.org/show_bug.cgi?id=108244
Is it a valid solution for the problem?
Builds with MSVC.
Comment 2 Zoltan Arvai 2013-01-30 10:10:09 PST 
Please review the fix to get Qt Windows bot's build working again.
Comment 3 WebKit Review Bot 2013-01-30 11:14:18 PST 
Comment on attachment 185500 [details]
build fix

Clearing flags on attachment: 185500

Committed r141287: <http://trac.webkit.org/changeset/141287>
Comment 4 WebKit Review Bot 2013-01-30 11:14:22 PST 
All reviewed patches have been landed.  Closing bug.