RESOLVED FIXED10832
Webkit WebCore build fails on Windows. 
https://bugs.webkit.org/show_bug.cgi?id=10832
Summary Webkit WebCore build fails on Windows.
Karthik Kumar
Reported 2006-09-13 05:12:37 PDT
Apparently in {$WebKit}/WebCore/bindings/scripts/CodeGenerator.pm, Line 211: $thisDir = "$ENV{SOURCE_ROOT}/$directory"; breaks. The only real way to fix it is to change it to: $thisDir = "/cygdrive/c/Webkit/WebCore/$directory"; (or some other absolute path) or change the cygwin config (.bashrc) and set the variable. Setting too many messy environmental variables is also hard. Suggestions: 1. Please make the script get the current directory and scan in it. 2. Use basename of the target idl file to be scanned and scan in it. 3. Re-document the build procedure.
Attachments
patch (535 bytes, patch)
2006-09-13 10:57 PDT, Darin Fisher (:fishd, Google) 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2006-09-13 05:15:34 PDT
This is also broken on the Windows build slave. SOURCE_ROOT appears to be automagically set from Xcode, so it is not available on Windows without the user manually setting it. IMO the path should be derived from the absolute path to the script being executed (similar to point 2 in Karthik's comment).
Mark Rowe (bdash)
Comment 2 2006-09-13 05:18:02 PDT
The use of SOURCE_ROOT was introduced in r16342 (http://trac.webkit.org/projects/webkit/changeset/16342).
Adam Roben (:aroben)
Comment 3 2006-09-13 10:18:05 PDT
Why not just set SOURCE_ROOT in build-generated-files.sh?
Darin Fisher (:fishd, Google)
Comment 4 2006-09-13 10:57:45 PDT
Created attachment 10537 [details] patch
Adam Roben (:aroben)
Comment 5 2006-09-13 10:59:29 PDT
Comment on attachment 10537 [details] patch r=me
Adam Roben (:aroben)
Comment 6 2006-09-13 11:08:23 PDT
Comment on attachment 10537 [details] patch Landed as r16345.
Note You need to log in before you can comment on or make changes to this bug.