WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108313
Web Inspector: migrate file selection dialog to the viewport.
https://bugs.webkit.org/show_bug.cgi?id=108313
Summary
Web Inspector: migrate file selection dialog to the viewport.
Pavel Feldman
Reported
2013-01-30 02:13:53 PST
Otherwise it takes too long to render.
Attachments
Patch
(27.73 KB, patch)
2013-01-30 02:15 PST
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(31.29 KB, patch)
2013-01-30 02:29 PST
,
Pavel Feldman
vsevik
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2013-01-30 02:15:40 PST
Created
attachment 185438
[details]
Patch
Pavel Feldman
Comment 2
2013-01-30 02:29:59 PST
Created
attachment 185441
[details]
Patch
Vsevolod Vlasov
Comment 3
2013-01-30 04:10:47 PST
Comment on
attachment 185441
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=185441&action=review
> Source/WebCore/ChangeLog:66 > + (WebInspector.ViewportControl.Provider.protowarning: LF will be replaced by CRLF in Source/WebCore/WebCore.vcproj/WebCore.vcproj.
Is that fine?
> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:544 > + setTimeout(function() { this._uiSourceCodes.sort(compareFunction); }.bind(this), 0);
setTimeout(this._uiSourceCodes.sort.bind(this._uiSourceCodes, compareFunction), 0);
Pavel Feldman
Comment 4
2013-01-30 04:49:14 PST
Committed
r141258
: <
http://trac.webkit.org/changeset/141258
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug