Bug 108313 - Web Inspector: migrate file selection dialog to the viewport.
Summary: Web Inspector: migrate file selection dialog to the viewport.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-30 02:13 PST by Pavel Feldman
Modified: 2013-01-30 04:49 PST (History)
8 users (show)

See Also:

Attachments
Patch (27.73 KB, patch)
2013-01-30 02:15 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (31.29 KB, patch)
2013-01-30 02:29 PST, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2013-01-30 02:13:53 PST 
Otherwise it takes too long to render.
Comment 1 Pavel Feldman 2013-01-30 02:15:40 PST 
Created attachment 185438 [details]
Patch
Comment 2 Pavel Feldman 2013-01-30 02:29:59 PST 
Created attachment 185441 [details]
Patch
Comment 3 Vsevolod Vlasov 2013-01-30 04:10:47 PST 
Comment on attachment 185441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185441&action=review

> Source/WebCore/ChangeLog:66
> +        (WebInspector.ViewportControl.Provider.protowarning: LF will be replaced by CRLF in Source/WebCore/WebCore.vcproj/WebCore.vcproj.

Is that fine?

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:544
> +        setTimeout(function() { this._uiSourceCodes.sort(compareFunction); }.bind(this), 0);

setTimeout(this._uiSourceCodes.sort.bind(this._uiSourceCodes, compareFunction), 0);
Comment 4 Pavel Feldman 2013-01-30 04:49:14 PST 
Committed r141258: <http://trac.webkit.org/changeset/141258>