Bug 108310 - GraphicsContext3DCG needs to copy image data in paintToCanvas
Summary: GraphicsContext3DCG needs to copy image data in paintToCanvas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 107804
  Show dependency treegraph
 
Reported: 2013-01-30 01:18 PST by Tim Horton
Modified: 2013-01-30 11:20 PST (History)
6 users (show)

See Also:


Attachments
patch (6.40 KB, patch)
2013-01-30 02:24 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-01-30 01:18:39 PST
In the case of paintToCanvas into an accelerated destination canvas, drawing may happen later, so we need to copy the pixel data. ImageBuffer already knows to do this, but this WebGL-specific function does not!
Comment 1 Tim Horton 2013-01-30 01:25:32 PST
https://bugs.webkit.org/show_bug.cgi?id=77185 was the fix for this for 2D canvas.
Comment 2 Tim Horton 2013-01-30 02:24:13 PST
Created attachment 185440 [details]
patch
Comment 3 Tim Horton 2013-01-30 11:20:30 PST
http://trac.webkit.org/changeset/141288