Bug 108304 – WebGL: Move the format conversion for 16-bit per channel formats into Core Graphics port only

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Jun Jiang]

Since the 16-bit per channel formats are only used for Core Graphics port in WebGL and not a standard to represent any file format that is widely used for each platform, it is better to limit and hide this kinds of information and processing in CG specific code only. It can make the code more clear and reduce the binary size for both CG port and non-CG port.

[Jun Jiang]

Created attachment 185417 [details]
Patch

[Kenneth Russell]

Comment on attachment 185417 [details]
Patch

Very nice work and simplification. Before setting the CQ bit, was this tested with all of the existing layout tests, WebGL conformance tests, and Mozilla's WebGLPerf test suite?

[Jun Jiang]

Hi, Kenneth. I used to test this patch using the existing Layout tests, Mozilla's WebGLPerf tests and WebGL 1.0.1 conformance tests. And it was OK.
Today I tried the latest WebGL conformance test in https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html(newer than version 1.0.1), and it met some issue(RGB8->RGBA32F conversion) for CG port when running safari on MAC. And it was related with another bug and I had submitted fix at https://bugs.webkit.org/show_bug.cgi?id=108812.

[Kenneth Russell]

Comment on attachment 185417 [details]
Patch

OK, sounds fine. Since the other bug is preexisting, doing these fixes separately sounds best. Thanks for the patch.

[WebKit Review Bot]

Comment on attachment 185417 [details]
Patch

Clearing flags on attachment: 185417

Committed r141841: <http://trac.webkit.org/changeset/141841>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.