Bug 108304 - WebGL: Move the format conversion for 16-bit per channel formats into Core Graphics port only
Summary: WebGL: Move the format conversion for 16-bit per channel formats into Core Gr...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jun Jiang
Depends on:
Reported: 2013-01-30 00:39 PST by Jun Jiang
Modified: 2013-02-04 18:13 PST (History)
3 users (show)

See Also:

Patch (38.08 KB, patch)
2013-01-30 00:46 PST, Jun Jiang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jun Jiang 2013-01-30 00:39:41 PST
Since the 16-bit per channel formats are only used for Core Graphics port in WebGL and not a standard to represent any file format that is widely used for each platform, it is better to limit and hide this kinds of information and processing in CG specific code only. It can make the code more clear and reduce the binary size for both CG port and non-CG port.
Comment 1 Jun Jiang 2013-01-30 00:46:41 PST
Created attachment 185417 [details]
Comment 2 Kenneth Russell 2013-02-02 14:37:12 PST
Comment on attachment 185417 [details]

Very nice work and simplification. Before setting the CQ bit, was this tested with all of the existing layout tests, WebGL conformance tests, and Mozilla's WebGLPerf test suite?
Comment 3 Jun Jiang 2013-02-04 04:30:29 PST
Hi, Kenneth. I used to test this patch using the existing Layout tests, Mozilla's WebGLPerf tests and WebGL 1.0.1 conformance tests. And it was OK.
Today I tried the latest WebGL conformance test in https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html(newer than version 1.0.1), and it met some issue(RGB8->RGBA32F conversion) for CG port when running safari on MAC. And it was related with another bug and I had submitted fix at https://bugs.webkit.org/show_bug.cgi?id=108812.
Comment 4 Kenneth Russell 2013-02-04 17:52:47 PST
Comment on attachment 185417 [details]

OK, sounds fine. Since the other bug is preexisting, doing these fixes separately sounds best. Thanks for the patch.
Comment 5 WebKit Review Bot 2013-02-04 18:13:06 PST
Comment on attachment 185417 [details]

Clearing flags on attachment: 185417

Committed r141841: <http://trac.webkit.org/changeset/141841>
Comment 6 WebKit Review Bot 2013-02-04 18:13:09 PST
All reviewed patches have been landed.  Closing bug.