Bug 108303 – Implement WheelEvent constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kentaro Hara]

Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm

UIEvent constructor can be implemented under a DOM4_EVENTS_CONSTRUCTOR flag, which is enabled on Chromium ans Safari.

[Kentaro Hara]

Created attachment 185415 [details]
Patch

[Kentaro Hara]

Comment on attachment 185415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185415&action=review

Also, I can implement WheelEvent.deltaMode in a follow-up patch if necessary. It corresponds to WheelEvent::m_granularity in WebCore implementation.

> LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt:96
> +FAIL new WheelEvent('eventType', { clientX: 2147483647 }).clientX should be 2147483647. Was -1.
> +PASS new WheelEvent('eventType', { clientX: -1 }).clientX is -1
> +FAIL new WheelEvent('eventType', { clientX: -2147483648 }).clientX should be -2147483648. Was 0.

These failures will be handled in https://bugs.webkit.org/show_bug.cgi?id=108305

> LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt:117
> +FAIL new WheelEvent('eventType', { clientY: 2147483647 }).clientY should be 2147483647. Was -1.
> +PASS new WheelEvent('eventType', { clientY: -1 }).clientY is -1
> +FAIL new WheelEvent('eventType', { clientY: -2147483648 }).clientY should be -2147483648. Was 0.

Ditto.

[Kentaro Hara]

Created attachment 185420 [details]
Patch

[WebKit Review Bot]

Attachment 185420 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt', u'LayoutTests/fast/events/constructors/wheel-event-constructor.html', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/platform/win/TestExpectations', u'LayoutTests/platform/wincairo/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/dom/WheelEvent.idl']" exit_code: 1
LayoutTests/platform/gtk/TestExpectations:394:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Created attachment 185422 [details]
Patch

[WebKit Review Bot]

Comment on attachment 185422 [details]
Patch

Attachment 185422 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16203573

[Kentaro Hara]

Created attachment 185429 [details]
Patch

[Kentaro Hara]

Created attachment 185431 [details]
Patch

[Build Bot]

Comment on attachment 185431 [details]
Patch

Attachment 185431 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16200579

New failing tests:
fast/dom/dom-constructors.html
fast/dom/constructed-objects-prototypes.html

[Kentaro Hara]

Created attachment 185459 [details]
Patch

[WebKit Review Bot]

Comment on attachment 185459 [details]
Patch

Clearing flags on attachment: 185459

Committed r141318: <http://trac.webkit.org/changeset/141318>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.