Bug 108303 - Implement WheelEvent constructor
Summary: Implement WheelEvent constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 67824
  Show dependency treegraph
 
Reported: 2013-01-30 00:35 PST by Kentaro Hara
Modified: 2013-01-30 14:45 PST (History)
9 users (show)

See Also:


Attachments
Patch (49.86 KB, patch)
2013-01-30 00:40 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (49.85 KB, patch)
2013-01-30 00:55 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (49.81 KB, patch)
2013-01-30 01:02 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (50.50 KB, patch)
2013-01-30 01:16 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (51.23 KB, patch)
2013-01-30 01:21 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (53.63 KB, patch)
2013-01-30 03:37 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-30 00:35:33 PST
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm

UIEvent constructor can be implemented under a DOM4_EVENTS_CONSTRUCTOR flag, which is enabled on Chromium ans Safari.
Comment 1 Kentaro Hara 2013-01-30 00:40:51 PST
Created attachment 185415 [details]
Patch
Comment 2 Kentaro Hara 2013-01-30 00:45:10 PST
Comment on attachment 185415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185415&action=review

Also, I can implement WheelEvent.deltaMode in a follow-up patch if necessary. It corresponds to WheelEvent::m_granularity in WebCore implementation.

> LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt:96
> +FAIL new WheelEvent('eventType', { clientX: 2147483647 }).clientX should be 2147483647. Was -1.
> +PASS new WheelEvent('eventType', { clientX: -1 }).clientX is -1
> +FAIL new WheelEvent('eventType', { clientX: -2147483648 }).clientX should be -2147483648. Was 0.

These failures will be handled in https://bugs.webkit.org/show_bug.cgi?id=108305

> LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt:117
> +FAIL new WheelEvent('eventType', { clientY: 2147483647 }).clientY should be 2147483647. Was -1.
> +PASS new WheelEvent('eventType', { clientY: -1 }).clientY is -1
> +FAIL new WheelEvent('eventType', { clientY: -2147483648 }).clientY should be -2147483648. Was 0.

Ditto.
Comment 3 Kentaro Hara 2013-01-30 00:55:05 PST
Created attachment 185420 [details]
Patch
Comment 4 WebKit Review Bot 2013-01-30 01:00:56 PST
Attachment 185420 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt', u'LayoutTests/fast/events/constructors/wheel-event-constructor.html', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/platform/win/TestExpectations', u'LayoutTests/platform/wincairo/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/dom/WheelEvent.idl']" exit_code: 1
LayoutTests/platform/gtk/TestExpectations:394:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Kentaro Hara 2013-01-30 01:02:52 PST
Created attachment 185422 [details]
Patch
Comment 6 WebKit Review Bot 2013-01-30 01:14:34 PST
Comment on attachment 185422 [details]
Patch

Attachment 185422 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16203573
Comment 7 Kentaro Hara 2013-01-30 01:16:45 PST
Created attachment 185429 [details]
Patch
Comment 8 Kentaro Hara 2013-01-30 01:21:25 PST
Created attachment 185431 [details]
Patch
Comment 9 Build Bot 2013-01-30 02:16:34 PST
Comment on attachment 185431 [details]
Patch

Attachment 185431 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16200579

New failing tests:
fast/dom/dom-constructors.html
fast/dom/constructed-objects-prototypes.html
Comment 10 Kentaro Hara 2013-01-30 03:37:27 PST
Created attachment 185459 [details]
Patch
Comment 11 WebKit Review Bot 2013-01-30 14:45:31 PST
Comment on attachment 185459 [details]
Patch

Clearing flags on attachment: 185459

Committed r141318: <http://trac.webkit.org/changeset/141318>
Comment 12 WebKit Review Bot 2013-01-30 14:45:36 PST
All reviewed patches have been landed.  Closing bug.