Bug 108291 - [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
Summary: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on: 107650
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-29 21:30 PST by Ryosuke Niwa
Modified: 2013-02-01 01:19 PST (History)
9 users (show)

See Also:

Attachments
patch (3.52 KB, patch)
2013-01-30 12:50 PST, chris fleizach 		rniwa: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-01-29 21:30:39 PST 
Fails with the following diff:

--- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/accessibility/lists-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/accessibility/lists-actual.txt
@@ -69,7 +69,7 @@
 ------------
 AXRole: AXList
 AXSubrole: AXDescriptionList
-AXRoleDescription: list
+AXRoleDescription: AXList:AXDescriptionList
 AXChildren: <array of size 5>
 AXHelp: 
 AXParent: <AXList>
Comment 1 Ryosuke Niwa 2013-01-29 21:38:02 PST 
Added a failing test expectation in http://trac.webkit.org/changeset/141220.
Comment 2 James Craig 2013-01-30 00:08:43 PST 
Actually I think we’d just want to replace the Lion expectation.txt file with the new actual results.
Comment 3 James Craig 2013-01-30 00:11:20 PST 
Never mind the previous comment, I read the diff backwards.
Comment 4 chris fleizach 2013-01-30 08:34:39 PST 
(In reply to comment #3)
> Never mind the previous comment, I read the diff backwards.

It looks like the problem is that we don't explicitly return the role description for a descriptionList, instead relying on the NSAccessibility method to return one and in Lion it returns the role:subrole, and above that it returns what the role's description would be ignoring the subrole.

i think we should mimic that behavior in WebCore otherwise, we'll get this unwieldy role description on lion
Comment 5 chris fleizach 2013-01-30 12:50:37 PST 
Created attachment 185540 [details]
patch
Comment 6 chris fleizach 2013-01-30 12:50:57 PST 
couldn't actually test this since i don't have a Lion machine, but it looks correct to me
Comment 7 Ryosuke Niwa 2013-01-30 13:00:29 PST 
(In reply to comment #6)
> couldn't actually test this since i don't have a Lion machine, but it looks correct to me

I do have a Lion machine at home so let me test on that when I get home tonight.
Comment 8 Build Bot 2013-01-30 14:13:57 PST 
Comment on attachment 185540 [details]
patch

Attachment 185540 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16195878

New failing tests:
platform/mac/fast/speechsynthesis/speech-synthesis-voices.html
Comment 9 chris fleizach 2013-01-30 16:19:48 PST 
Comment on attachment 185540 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185540&action=review

> LayoutTests/platform/mac/TestExpectations:192
> +# platform/mac/fast/speechsynthesis

whoops obviously did not mean to enable that. will remove this line if this patch is r+
Comment 10 Ryosuke Niwa 2013-01-31 22:46:29 PST 
Comment on attachment 185540 [details]
patch

Confirmed that the list.html passes on Lion.
Comment 11 chris fleizach 2013-02-01 01:14:06 PST 
huzzah! thanks for taking the time to confirm
Comment 12 chris fleizach 2013-02-01 01:19:05 PST 
http://trac.webkit.org/changeset/141559