Bug 108291 – [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Ryosuke Niwa]

Fails with the following diff:

--- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/accessibility/lists-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/accessibility/lists-actual.txt
@@ -69,7 +69,7 @@
 ------------
 AXRole: AXList
 AXSubrole: AXDescriptionList
-AXRoleDescription: list
+AXRoleDescription: AXList:AXDescriptionList
 AXChildren: <array of size 5>
 AXHelp: 
 AXParent: <AXList>

[Ryosuke Niwa]

Added a failing test expectation in http://trac.webkit.org/changeset/141220.

[James Craig]

Actually I think we’d just want to replace the Lion expectation.txt file with the new actual results.

[James Craig]

Never mind the previous comment, I read the diff backwards.

[chris fleizach]

(In reply to comment #3)
> Never mind the previous comment, I read the diff backwards.

It looks like the problem is that we don't explicitly return the role description for a descriptionList, instead relying on the NSAccessibility method to return one and in Lion it returns the role:subrole, and above that it returns what the role's description would be ignoring the subrole.

i think we should mimic that behavior in WebCore otherwise, we'll get this unwieldy role description on lion

[chris fleizach]

Created attachment 185540 [details]
patch

[chris fleizach]

couldn't actually test this since i don't have a Lion machine, but it looks correct to me

[Ryosuke Niwa]

(In reply to comment #6)
> couldn't actually test this since i don't have a Lion machine, but it looks correct to me

I do have a Lion machine at home so let me test on that when I get home tonight.

[Build Bot]

Comment on attachment 185540 [details]
patch

Attachment 185540 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16195878

New failing tests:
platform/mac/fast/speechsynthesis/speech-synthesis-voices.html

[chris fleizach]

Comment on attachment 185540 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185540&action=review

> LayoutTests/platform/mac/TestExpectations:192
> +# platform/mac/fast/speechsynthesis

whoops obviously did not mean to enable that. will remove this line if this patch is r+

[Ryosuke Niwa]

Comment on attachment 185540 [details]
patch

Confirmed that the list.html passes on Lion.

[chris fleizach]

huzzah! thanks for taking the time to confirm

[chris fleizach]

http://trac.webkit.org/changeset/141559