Bug 108275 – webdatabase: Rename AbstractDatabase to DatabaseBackend

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mark Lam]

This is a sub-task of https://bugs.webkit.org/show_bug.cgi?id=107475.  Breaking out as a step for easier review.  This patch should be purely a rename operation.  There are no semantic changes.

[Mark Lam]

Created attachment 185373 [details]
the patch.

Apart from the renaming, I had to do a couple of minor touches to keep the style checker happy.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 185373 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/webdatabase/AbstractDatabase.cpp', u'Source/WebCore/Modules/webdatabase/AbstractDatabase.h', u'Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h', u'Source/WebCore/Modules/webdatabase/DBBackendServer.cpp', u'Source/WebCore/Modules/webdatabase/DBBackendServer.h', u'Source/WebCore/Modules/webdatabase/Database.cpp', u'Source/WebCore/Modules/webdatabase/Database.h', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.h', u'Source/WebCore/Modules/webdatabase/DatabaseManager.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseManager.h', u'Source/WebCore/Modules/webdatabase/DatabaseSync.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseSync.h', u'Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTracker.h', u'Source/WebCore/Modules/webdatabase/OriginQuotaManager.cpp', u'Source/WebCore/Modules/webdatabase/OriginQuotaManager.h', u'Source/WebCore/Modules/webdatabase/SQLTransactionClient.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionClient.h', u'Source/WebCore/Modules/webdatabase/chromium/DatabaseObserver.h', u'Source/WebCore/Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp', u'Source/WebCore/Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/public/WebDatabase.h', u'Source/WebKit/chromium/src/DatabaseObserver.cpp', u'Source/WebKit/chromium/src/WebDatabase.cpp']" exit_code: 1
Source/WebCore/Modules/webdatabase/DatabaseBackend.h:80:  The parameter name "permissions" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kent Tamura]

Comment on attachment 185373 [details]
the patch.

The WebKit/chromium/public/WebDatabase.h change looks good.

[Mark Lam]

Landed in r141207: <http://trac.webkit.org/changeset/141207>.

[Ryosuke Niwa]

It seems like this patch caused a Win Debug build failure?

http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/61510

But maybe this is a build fluke :(

[Ryosuke Niwa]

+rfong to notify him of a possible win dbg build failure.

[Jussi Kukkonen (jku)]

efl bot started asserting quite often on fast/js/caller-property.html soon after this commit: bug 108355.

[Mark Lam]

(In reply to comment #8)
> efl bot started asserting quite often on fast/js/caller-property.html soon after this commit: bug 108355.

This is a misdiagnosis.  This bug is only a rename operation and cannot cause a new failure like this.