RESOLVED FIXED 108273
Remove use of plugInStartLabelImage 
https://bugs.webkit.org/show_bug.cgi?id=108273
Summary Remove use of plugInStartLabelImage
Dean Jackson
Reported 2013-01-29 17:56:39 PST
When snapshotted plugins start using a shadow root, they won't need this code.
Attachments
Patch (10.93 KB, patch)
2013-01-29 18:10 PST, Dean Jackson 		simon.fraser: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-01-29 17:56:49 PST
<rdar://problem/13112117>
Dean Jackson
Comment 2 2013-01-29 18:10:05 PST
Created attachment 185365 [details] Patch
Jon Lee
Comment 3 2013-01-29 18:16:44 PST
Unofficial r=me.
Early Warning System Bot
Comment 4 2013-01-29 18:17:35 PST
Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16200403
Simon Fraser (smfr)
Comment 5 2013-01-29 18:19:34 PST
Comment on attachment 185365 [details] Patch r=me but please fix Qt.
Dean Jackson
Comment 6 2013-01-29 18:24:38 PST
I think all EWS will fail because this is removing code that is still being called in the tree (subsequent patch). I'll stage this commit later, and check EWS first.
Build Bot
Comment 7 2013-01-29 18:39:35 PST
Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16115490
WebKit Review Bot
Comment 8 2013-01-29 19:05:40 PST
Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16199410
Peter Beverloo (cr-android ews)
Comment 9 2013-01-29 19:20:26 PST
Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16217258
Build Bot
Comment 10 2013-01-29 19:26:26 PST
Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16022528
Early Warning System Bot
Comment 11 2013-01-29 19:32:16 PST
Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16201420
Build Bot
Comment 12 2013-01-29 20:40:35 PST
Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16115528
EFL EWS Bot
Comment 13 2013-01-29 22:08:40 PST
Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16218316
Dean Jackson
Comment 14 2013-02-08 20:24:19 PST
Committed r142347: <http://trac.webkit.org/changeset/142347>
Kent Tamura
Comment 15 2013-02-10 08:38:02 PST
(In reply to comment #14) > Committed r142347: <http://trac.webkit.org/changeset/142347> I'm rolling it out because I rolled out the depending http://trac.webkit.org/changeset/142343. Please see Bug 108284.
Kent Tamura
Comment 16 2013-02-10 08:41:05 PST
Reverted r142347 for reason: Because a depending change r142343 was rolled out. Committed r142405: <http://trac.webkit.org/changeset/142405>
Dean Jackson
Comment 17 2013-02-12 10:35:04 PST
Landed again in r142507
Note You need to log in before you can comment on or make changes to this bug.