Bug 108271 - Do not register autostart for plugins from file:// (or nowhere)
Summary: Do not register autostart for plugins from file:// (or nowhere)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-29 17:40 PST by Dean Jackson
Modified: 2013-02-08 12:27 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2013-01-29 17:45 PST, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-01-29 17:40:04 PST
PlugIns that come from a file:// origin should never be added to the autostart list.
Comment 1 Dean Jackson 2013-01-29 17:41:17 PST
<rdar://problem/13037458>
Comment 2 Dean Jackson 2013-01-29 17:45:55 PST
Created attachment 185364 [details]
Patch
Comment 3 Tim Horton 2013-01-29 18:32:43 PST
Comment on attachment 185364 [details]
Patch

Do we really need the log?
Comment 4 Tim Horton 2013-01-29 18:33:13 PST
Comment on attachment 185364 [details]
Patch

Also somewhat surprised we don't have something somewhere to match file://
Comment 5 Tim Horton 2013-01-29 18:39:32 PST
Maybe you should use SchemeRegistry::shouldTreatURLSchemeAsLocal, if you know how to split the scheme off.
Comment 6 Dean Jackson 2013-02-08 12:27:04 PST
Committed r142310: <http://trac.webkit.org/changeset/142310>