Bug 108269 - Remove MessageID parameter from Connection::sendMessage
Summary: Remove MessageID parameter from Connection::sendMessage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-29 17:30 PST by Anders Carlsson
Modified: 2013-01-29 17:40 PST (History)
1 user (show)

See Also:

Attachments
Patch (13.26 KB, patch)
2013-01-29 17:33 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-01-29 17:30:29 PST 
Remove MessageID parameter from Connection::sendMessage
Comment 1 Anders Carlsson 2013-01-29 17:33:11 PST 
Created attachment 185357 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-29 17:36:23 PST 
Attachment 185357 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp', u'Source/WebKit2/Platform/CoreIPC/Connection.h', u'Source/WebKit2/Platform/CoreIPC/MessageSender.h', u'Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp', u'Source/WebKit2/Shared/ChildProcessProxy.cpp', u'Source/WebKit2/Shared/WebConnection.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp']" exit_code: 1
Source/WebKit2/Platform/CoreIPC/Connection.h:184:  Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebKit2/Platform/CoreIPC/Connection.h:185:  Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-01-29 17:40:39 PST 
Committed r141191: <http://trac.webkit.org/changeset/141191>