Bug 108266 – TransformState::move should not round offset to int

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Emil A Eklund]

Currently TransformState::move rounds the offset to the nearest integer values, this results in operations using TransformState to compute a position to misreport the location, specifically Element:getBoundingClientRect and repaint rects. Sizes are handled correctly and do not have the same problem.

[Emil A Eklund]

Created attachment 185353 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 185353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185353&action=review

> Source/WebCore/platform/graphics/transforms/TransformState.cpp:69
>  void TransformState::translateMappedCoordinates(const IntSize& offset)

Do we still need these Int versions?

[Emil A Eklund]

(In reply to comment #2)
> (From update of attachment 185353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185353&action=review
> 
> > Source/WebCore/platform/graphics/transforms/TransformState.cpp:69
> >  void TransformState::translateMappedCoordinates(const IntSize& offset)
> 
> Do we still need these Int versions?

Not really. Was trying to avoid upcasting from int to LayoutUnit for callers that use an IntSize.

[Build Bot]

Comment on attachment 185353 [details]
Patch

Attachment 185353 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16115498

New failing tests:
accessibility/image-link.html
accessibility/table-sections.html
accessibility/table-cell-spans.html
accessibility/table-detection.html
accessibility/table-cells.html
fast/dom/Window/webkitConvertPoint.html
accessibility/internal-link-anchors2.html
accessibility/table-attributes.html

[Build Bot]

Comment on attachment 185353 [details]
Patch

Attachment 185353 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16202518

New failing tests:
accessibility/image-link.html
accessibility/table-sections.html
accessibility/table-cell-spans.html
accessibility/table-detection.html
accessibility/table-cells.html
fast/dom/Window/webkitConvertPoint.html
accessibility/internal-link-anchors2.html
accessibility/table-attributes.html

[Emil A Eklund]

Comment on attachment 185353 [details]
Patch

Turns out this breaks repainting of iframes positioned on sunpixel boundaries in some cases. Marking as obsolete until for now.

[Emil A Eklund]

Created attachment 187657 [details]
Patch

[WebKit Review Bot]

Comment on attachment 187657 [details]
Patch

Attachment 187657 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16499347

New failing tests:
platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html
platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar.html
platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar.html

[Emil A Eklund]

(In reply to comment #8)
> (From update of attachment 187657 [details])
> Attachment 187657 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/16499347
> 
> New failing tests:
> platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html
> platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar.html
> platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar.html

Odd, all the platform/chromium/fast/forms/suggestion-picker tests pass for me on chromium linux.

[Emil A Eklund]

The platform/chromium/fast/forms/suggestion-picker tests fail to due to a one pixel difference in scrolling when calling Element.focus() to scroll-to-reveal. In trying to fix the suggestionPicker.js to avoid this I found a bunch of other scrolling inconsistencies so I'm going to rewrite how we do scrolling in suggestion pickers. Tracked by bug 109528.

[Emil A Eklund]

Created attachment 187747 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 187747 [details]
Patch for landing

Clearing flags on attachment: 187747

Committed r142638: <http://trac.webkit.org/changeset/142638>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.