Bug 108248 - Remove willAddAuthorShadowRoot and replace with alwaysCreateUserAgentShadowRoot
Summary: Remove willAddAuthorShadowRoot and replace with alwaysCreateUserAgentShadowRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-29 16:31 PST by Elliott Sprehn
Modified: 2013-01-30 11:42 PST (History)
12 users (show)

See Also:

Attachments
Patch (9.36 KB, patch)
2013-01-29 16:40 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch (7.85 KB, patch)
2013-01-29 16:43 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch (7.82 KB, patch)
2013-01-29 22:51 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch (7.91 KB, patch)
2013-01-30 01:04 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch for landing (7.82 KB, patch)
2013-01-30 10:14 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2013-01-29 16:31:00 PST 
Remove willAddAuthorShadowRoot and replace with alwaysCreateUserAgentShadowRoot
Comment 1 Elliott Sprehn 2013-01-29 16:40:24 PST 
Created attachment 185342 [details]
Patch
Comment 2 Elliott Sprehn 2013-01-29 16:43:26 PST 
Created attachment 185344 [details]
Patch
Comment 3 Build Bot 2013-01-29 17:19:11 PST 
Comment on attachment 185344 [details]
Patch

Attachment 185344 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16200370
Comment 4 Elliott Sprehn 2013-01-29 17:24:48 PST 
Err, getting rid of that argument would be good, but it's silly since I have to bring it right back for the next patch, so I'll upload that first.
Comment 5 Build Bot 2013-01-29 17:59:00 PST 
Comment on attachment 185344 [details]
Patch

Attachment 185344 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16151443
Comment 6 WebKit Review Bot 2013-01-29 18:13:11 PST 
Comment on attachment 185344 [details]
Patch

Attachment 185344 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16187436

New failing tests:
fast/dom/shadow/shadowdom-for-media.html
Comment 7 WebKit Review Bot 2013-01-29 19:40:11 PST 
Comment on attachment 185344 [details]
Patch

Attachment 185344 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16202410

New failing tests:
fast/dom/shadow/shadowdom-for-media.html
Comment 8 Elliott Sprehn 2013-01-29 22:51:32 PST 
Created attachment 185399 [details]
Patch
Comment 9 Elliott Sprehn 2013-01-30 01:01:30 PST 
(In reply to comment #7)
> (From update of attachment 185344 [details])
> Attachment 185344 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/16202410
> 
> New failing tests:
> fast/dom/shadow/shadowdom-for-media.html

Apparently this test forces shadow DOM "on" even for elements that say author shadows are not allowed, so my removing the check broke it.
Comment 10 Elliott Sprehn 2013-01-30 01:04:16 PST 
Created attachment 185423 [details]
Patch
Comment 11 WebKit Review Bot 2013-01-30 09:59:20 PST 
Comment on attachment 185423 [details]
Patch

Rejecting attachment 185423 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 185423, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
 file Source/WebCore/html/HTMLFormControlElement.cpp
patching file Source/WebCore/html/HTMLFormControlElement.h
patching file Source/WebCore/html/HTMLMediaElement.cpp
patching file Source/WebCore/html/HTMLMediaElement.h
Hunk #1 FAILED at 88.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLMediaElement.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Dimitri Glazkov']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16199764
Comment 12 Elliott Sprehn 2013-01-30 10:14:50 PST 
Created attachment 185514 [details]
Patch for landing
Comment 13 WebKit Review Bot 2013-01-30 11:42:39 PST 
Comment on attachment 185514 [details]
Patch for landing

Clearing flags on attachment: 185514

Committed r141292: <http://trac.webkit.org/changeset/141292>
Comment 14 WebKit Review Bot 2013-01-30 11:42:43 PST 
All reviewed patches have been landed.  Closing bug.