Bug 108248 – Remove willAddAuthorShadowRoot and replace with alwaysCreateUserAgentShadowRoot

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Elliott Sprehn]

Remove willAddAuthorShadowRoot and replace with alwaysCreateUserAgentShadowRoot

[Elliott Sprehn]

Created attachment 185342 [details]
Patch

[Elliott Sprehn]

Created attachment 185344 [details]
Patch

[Build Bot]

Comment on attachment 185344 [details]
Patch

Attachment 185344 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16200370

[Elliott Sprehn]

Err, getting rid of that argument would be good, but it's silly since I have to bring it right back for the next patch, so I'll upload that first.

[Build Bot]

Comment on attachment 185344 [details]
Patch

Attachment 185344 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16151443

[WebKit Review Bot]

Comment on attachment 185344 [details]
Patch

Attachment 185344 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16187436

New failing tests:
fast/dom/shadow/shadowdom-for-media.html

[WebKit Review Bot]

Comment on attachment 185344 [details]
Patch

Attachment 185344 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16202410

New failing tests:
fast/dom/shadow/shadowdom-for-media.html

[Elliott Sprehn]

Created attachment 185399 [details]
Patch

[Elliott Sprehn]

(In reply to comment #7)
> (From update of attachment 185344 [details])
> Attachment 185344 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/16202410
> 
> New failing tests:
> fast/dom/shadow/shadowdom-for-media.html

Apparently this test forces shadow DOM "on" even for elements that say author shadows are not allowed, so my removing the check broke it.

[Elliott Sprehn]

Created attachment 185423 [details]
Patch

[WebKit Review Bot]

Comment on attachment 185423 [details]
Patch

Rejecting attachment 185423 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 185423, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
 file Source/WebCore/html/HTMLFormControlElement.cpp
patching file Source/WebCore/html/HTMLFormControlElement.h
patching file Source/WebCore/html/HTMLMediaElement.cpp
patching file Source/WebCore/html/HTMLMediaElement.h
Hunk #1 FAILED at 88.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLMediaElement.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Dimitri Glazkov']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16199764

[Elliott Sprehn]

Created attachment 185514 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 185514 [details]
Patch for landing

Clearing flags on attachment: 185514

Committed r141292: <http://trac.webkit.org/changeset/141292>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.