Bug 108224 - BUILD FIX: Make WebCorePrefix.h build on iOS
Summary: BUILD FIX: Make WebCorePrefix.h build on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-29 13:48 PST by David Kilzer (:ddkilzer)
Modified: 2013-01-30 10:28 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2013-01-29 13:48 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-01-29 13:48:15 PST
<http://webkit.org/b/000000>

Reviewed by NOBODY (OOPS!).

* WebCorePrefix.h:
- Include <wtf/Platform.h>.
- Do not include <CoreServices/CoreServices.h> on iOS.
- Include <Foundation/Foundation.h> instead of <Cocoa/Cocoa.h>
on iOS.
---
 2 files changed, 23 insertions(+), 2 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2013-01-29 13:48:16 PST
Created attachment 185301 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2013-01-29 13:52:13 PST
Was Platform.h not included in WebCorePrefix.h for a reason?  (Maybe to force config.h to be included in all source files, or to prevent ENABLE(), USE(), PLATFORM(), etc. macros from appearing in headers?)
Comment 3 WebKit Review Bot 2013-01-30 04:23:01 PST
Comment on attachment 185301 [details]
Patch

Clearing flags on attachment: 185301

Committed r141254: <http://trac.webkit.org/changeset/141254>
Comment 4 WebKit Review Bot 2013-01-30 04:23:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 David Kilzer (:ddkilzer) 2013-01-30 10:28:10 PST
(In reply to comment #2)
> Was Platform.h not included in WebCorePrefix.h for a reason?  (Maybe to force config.h to be included in all source files, or to prevent ENABLE(), USE(), PLATFORM(), etc. macros from appearing in headers?)

Note that the Tools/Scripts/check-for-inappropriate-macros-in-external-headers script now checks for those macros appearing in public headers.