Bug 108211 - Add RenderLayer::enclosingStackingContainer
Summary: Add RenderLayer::enclosingStackingContainer
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: vollick
Depends on:
Reported: 2013-01-29 11:54 PST by vollick
Modified: 2013-01-29 13:24 PST (History)
5 users (show)

See Also:

Patch (1.83 KB, patch)
2013-01-29 12:05 PST, vollick
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description vollick 2013-01-29 11:54:12 PST
This function is similar to RenderLayer::stackingContainer, but may return the layer itself if it's a stacking container.
Comment 1 vollick 2013-01-29 12:05:51 PST
Created attachment 185279 [details]
Comment 2 Simon Fraser (smfr) 2013-01-29 12:10:58 PST
Comment on attachment 185279 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=185279&action=review

> Source/WebCore/rendering/RenderLayer.h:446
> +    RenderLayer* enclosingStackingContainer() { return isStackingContainer() ? this : stackingContainer(); }

Should be const.
Comment 3 vollick 2013-01-29 12:51:38 PST
I should mention for folks not following #webkit, the reason I'd gone ahead and cq+'d the patch was because making enclosingStackingContainer const would prevent me from returning 'this' as a non-const RenderLayer*. Going with the patch as-is was the consensus in the channel.
Comment 4 WebKit Review Bot 2013-01-29 13:23:52 PST
Comment on attachment 185279 [details]

Rejecting attachment 185279 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 185279, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
rce/WebKit/chromium/webkit/media/crypto/ppapi/cdm --revision 173055 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
56>At revision 173055.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/16202287
Comment 5 WebKit Review Bot 2013-01-29 13:23:59 PST
Comment on attachment 185279 [details]

Clearing flags on attachment: 185279

Committed r141159: <http://trac.webkit.org/changeset/141159>
Comment 6 WebKit Review Bot 2013-01-29 13:24:02 PST
All reviewed patches have been landed.  Closing bug.