Bug 108191 - Consolidate the way WTF_USE_PTHREADS is enabled
Summary: Consolidate the way WTF_USE_PTHREADS is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-29 07:04 PST by Laszlo Gombos
Modified: 2013-02-10 13:05 PST (History)
8 users (show)

See Also:

Attachments
cleanup (3.86 KB, patch)
2013-02-03 04:58 PST, Laszlo Gombos 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
for cq (4.15 KB, patch)
2013-02-10 08:49 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-01-29 07:04:23 PST 
It seems to me that WTF_USE_PTHREADS can be defined with the following simple rule in Platform.h:

#if OS(UNIX)
#define WTF_USE_PTHREADS 1
#endif

Currently we have various other means (at last count 8 - some in port specific build systems) to enable WTF_USE_PTHREADS for the various build configurations.
Comment 1 Laszlo Gombos 2013-02-03 04:58:56 PST 
Created attachment 186260 [details]
cleanup
Comment 2 Build Bot 2013-02-03 07:19:56 PST 
Comment on attachment 186260 [details]
cleanup

Attachment 186260 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16346687
Comment 3 Build Bot 2013-02-03 08:06:57 PST 
Comment on attachment 186260 [details]
cleanup

Attachment 186260 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16346711
Comment 4 Laszlo Gombos 2013-02-05 12:33:34 PST 
(In reply to comment #3)
> (From update of attachment 186260 [details])
> Attachment 186260 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16346711

This seems to be an unrelated failure, removing cq-.
Comment 5 Benjamin Poulain 2013-02-05 13:10:02 PST 
Comment on attachment 186260 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=186260&action=review

> Source/WTF/wtf/Platform.h:668
> +#if OS(UNIX)
>  #define WTF_USE_PTHREADS 1
>  #endif

Instead, consolidate the OS(UNIX) section. Remove this one and move WTF_USE_PTHREADS to the existing section.
Comment 6 Laszlo Gombos 2013-02-10 08:49:33 PST 
Created attachment 187481 [details]
for cq
Comment 7 WebKit Review Bot 2013-02-10 13:05:38 PST 
Comment on attachment 187481 [details]
for cq

Clearing flags on attachment: 187481

Committed r142417: <http://trac.webkit.org/changeset/142417>
Comment 8 WebKit Review Bot 2013-02-10 13:05:43 PST 
All reviewed patches have been landed.  Closing bug.