RESOLVED CONFIGURATION CHANGED 108188
[WIN] Use CF to format date 
https://bugs.webkit.org/show_bug.cgi?id=108188
Summary [WIN] Use CF to format date
Laszlo Gombos
Reported 2013-01-29 06:23:01 PST
CF is belied to be superior to the strftime-based version. Consider using CF to format date on Windows as well.
Attachments
Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2013-01-29 06:25:11 PST
See the FIXME in JavaScriptCore/runtime/DatePrototype.cpp and the discussion at bug 107406 .
Brent Fulgham
Comment 2 2013-01-29 11:47:08 PST
I assume the FIXME you refer to is: static const int yearLen = 5; // FIXME will be a problem in the year 10,000 :-)
Brent Fulgham
Comment 3 2013-01-29 12:01:50 PST
I agree with this patch in principle. I think the set of tests would be better handled as a "USE(CF)", since that seems to be what the current logic is attempting to do. The only thing I am unsure of is whether there is any performance impact to making this change. Maybe one of the JavaScriptCore experts could let us know if this might be an issue. It seems unlikely that this would be a problem.
Ahmad Saleem
Comment 4 2023-10-20 07:36:29 PDT
I am unable to find this FIXME and was this specific to AppleWin port or win-cairo was also impacted and whether we need to do anything? @Brent & @Fuji - any input?
Brent Fulgham
Comment 5 2023-10-20 09:31:48 PDT
This is no longer relevant. The modern Windows ports no longer use CoreFoundation or CFLite.
Note You need to log in before you can comment on or make changes to this bug.