Bug 108188 - [WIN] Use CF to format date
Summary: [WIN] Use CF to format date
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-29 06:23 PST by Laszlo Gombos
Modified: 2013-01-29 12:01 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-01-29 06:23:01 PST
CF is belied to be superior to the strftime-based version. Consider using CF to format date on Windows as well.
Comment 1 Laszlo Gombos 2013-01-29 06:25:11 PST
See the FIXME in JavaScriptCore/runtime/DatePrototype.cpp and the discussion at bug 107406 .
Comment 2 Brent Fulgham 2013-01-29 11:47:08 PST
I assume the FIXME you refer to is:

static const int yearLen = 5;   // FIXME will be a problem in the year 10,000


:-)
Comment 3 Brent Fulgham 2013-01-29 12:01:50 PST
I agree with this patch in principle.  I think the set of tests would be better handled as a "USE(CF)", since that seems to be what the current logic is attempting to do.

The only thing I am unsure of is whether there is any performance impact to making this change.  Maybe one of the JavaScriptCore experts could let us know if this might be an issue. It seems unlikely that this would be a problem.