Bug 108185 - Canvas support for isPointInStroke
Summary: Canvas support for isPointInStroke
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL: https://bugzilla.mozilla.org/show_bug...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-29 05:35 PST by Dirk Schulze
Modified: 2013-01-29 12:28 PST (History)
7 users (show)

See Also:

Attachments
Patch (12.35 KB, patch)
2013-01-29 05:48 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Patch (13.24 KB, patch)
2013-01-29 07:09 PST, Dirk Schulze 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2013-01-29 05:35:24 PST 
Firefox implemented isPointInStroke unprefixed. We should do the same, since this seems to be a really useful function. See link to Firefox bug report.
Comment 1 Dirk Schulze 2013-01-29 05:48:46 PST 
Created attachment 185227 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-29 06:52:54 PST 
Comment on attachment 185227 [details]
Patch

Attachment 185227 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16183173

New failing tests:
inspector/profiler/canvas2d/canvas2d-api-changes.html
Comment 3 Dirk Schulze 2013-01-29 07:09:10 PST 
Created attachment 185236 [details]
Patch
Comment 4 Dean Jackson 2013-01-29 09:55:05 PST 
Comment on attachment 185236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185236&action=review

> Source/WebCore/ChangeLog:12
> +        Firfox implemented isPointInStroke originaly and unprefixed it recently:

Typos: Firefox and originally

> Source/WebCore/ChangeLog:20
> +        (WebCore):

I really should submit a patch to prepareChangeLog so that it doesn't spit out these useless lines. In this case, I think the change in the comment triggered it.
Comment 5 Dirk Schulze 2013-01-29 12:28:27 PST 
Committed r141141: <http://trac.webkit.org/changeset/141141>