Bug 108181 - Web Inspector: Change the Elements panel sidebar layout based on its aspect ratio.
Summary: Web Inspector: Change the Elements panel sidebar layout based on its aspect r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vladislav Kaznacheev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-29 05:08 PST by Vladislav Kaznacheev
Modified: 2013-01-30 04:01 PST (History)
10 users (show)

See Also:

Attachments
Patch (9.51 KB, patch)
2013-01-29 05:16 PST, Vladislav Kaznacheev 		no flags Details | Formatted Diff | Diff
Patch (18.00 KB, patch)
2013-01-30 01:01 PST, Vladislav Kaznacheev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladislav Kaznacheev 2013-01-29 05:08:04 PST 
A followup to https://bugs.webkit.org/show_bug.cgi?id=107129. 
The sidebar layout should depend on the sidebar aspect ratio, not the docking mode.
Comment 1 Vladislav Kaznacheev 2013-01-29 05:16:02 PST 
Created attachment 185220 [details]
Patch
Comment 2 Pavel Feldman 2013-01-29 07:07:15 PST 
Comment on attachment 185220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185220&action=review

> Source/WebCore/inspector/front-end/SidebarView.js:66
> +    Start: "Start",

Why would we need Left, Right, Top and Bottom then? Start/End + orientation uniquely identify it.
Comment 3 Vladislav Kaznacheev 2013-01-30 01:01:22 PST 
Created attachment 185421 [details]
Patch
Comment 4 WebKit Review Bot 2013-01-30 04:01:16 PST 
Comment on attachment 185421 [details]
Patch

Clearing flags on attachment: 185421

Committed r141249: <http://trac.webkit.org/changeset/141249>
Comment 5 WebKit Review Bot 2013-01-30 04:01:21 PST 
All reviewed patches have been landed.  Closing bug.