WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108170
[HarfBuzz] Naming fixes after removing old HarfBuzz code
https://bugs.webkit.org/show_bug.cgi?id=108170
Summary
[HarfBuzz] Naming fixes after removing old HarfBuzz code
Dominik Röttsches (drott)
Reported
2013-01-29 01:44:54 PST
HarfBuzzNGFace should become HarfBuzzFace, harfbuzzFace() should be harfBuzzFace(), m_harfbuzzFace should be m_harfBuzzFace.
Attachments
Patch
(140.37 KB, patch)
2013-01-30 06:22 PST
,
Dominik Röttsches (drott)
no flags
Details
Formatted Diff
Diff
Patch
(140.37 KB, patch)
2013-01-30 06:50 PST
,
Dominik Röttsches (drott)
no flags
Details
Formatted Diff
Diff
Patch v3, Chromium buildfix.
(140.37 KB, patch)
2013-01-30 07:40 PST
,
Dominik Röttsches (drott)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2013-01-29 12:04:07 PST
Ah, sorry, just said the same thing on the dependant bug. Sounds great!
Dominik Röttsches (drott)
Comment 2
2013-01-29 13:05:29 PST
Yep, also, let's move the files out of the NG folder - as discussed.
Dominik Röttsches (drott)
Comment 3
2013-01-30 06:22:46 PST
Created
attachment 185486
[details]
Patch
Dominik Röttsches (drott)
Comment 4
2013-01-30 06:50:10 PST
Created
attachment 185494
[details]
Patch
WebKit Review Bot
Comment 5
2013-01-30 07:27:17 PST
Comment on
attachment 185494
[details]
Patch
Attachment 185494
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/16202719
Peter Beverloo (cr-android ews)
Comment 6
2013-01-30 07:37:45 PST
Comment on
attachment 185494
[details]
Patch
Attachment 185494
[details]
did not pass cr-android-ews (chromium-android): Output:
http://queues.webkit.org/results/16115795
Dominik Röttsches (drott)
Comment 7
2013-01-30 07:40:17 PST
Created
attachment 185503
[details]
Patch v3, Chromium buildfix.
Dominik Röttsches (drott)
Comment 8
2013-01-30 11:13:59 PST
Thanks for the review, Tony.
WebKit Review Bot
Comment 9
2013-01-30 11:41:09 PST
Comment on
attachment 185503
[details]
Patch v3, Chromium buildfix. Clearing flags on attachment: 185503 Committed
r141291
: <
http://trac.webkit.org/changeset/141291
>
WebKit Review Bot
Comment 10
2013-01-30 11:41:14 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug