Bug 108170 - [HarfBuzz] Naming fixes after removing old HarfBuzz code
Summary: [HarfBuzz] Naming fixes after removing old HarfBuzz code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on: 108077
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-29 01:44 PST by Dominik Röttsches (drott)
Modified: 2013-01-30 11:41 PST (History)
8 users (show)

See Also:

Attachments
Patch (140.37 KB, patch)
2013-01-30 06:22 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Patch (140.37 KB, patch)
2013-01-30 06:50 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Patch v3, Chromium buildfix. (140.37 KB, patch)
2013-01-30 07:40 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2013-01-29 01:44:54 PST 
HarfBuzzNGFace should become HarfBuzzFace,
harfbuzzFace() should be harfBuzzFace(),
m_harfbuzzFace should be m_harfBuzzFace.
Comment 1 Tony Chang 2013-01-29 12:04:07 PST 
Ah, sorry, just said the same thing on the dependant bug.  Sounds great!
Comment 2 Dominik Röttsches (drott) 2013-01-29 13:05:29 PST 
Yep, also, let's move the files out of the NG folder - as discussed.
Comment 3 Dominik Röttsches (drott) 2013-01-30 06:22:46 PST 
Created attachment 185486 [details]
Patch
Comment 4 Dominik Röttsches (drott) 2013-01-30 06:50:10 PST 
Created attachment 185494 [details]
Patch
Comment 5 WebKit Review Bot 2013-01-30 07:27:17 PST 
Comment on attachment 185494 [details]
Patch

Attachment 185494 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16202719
Comment 6 Peter Beverloo (cr-android ews) 2013-01-30 07:37:45 PST 
Comment on attachment 185494 [details]
Patch

Attachment 185494 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16115795
Comment 7 Dominik Röttsches (drott) 2013-01-30 07:40:17 PST 
Created attachment 185503 [details]
Patch v3, Chromium buildfix.
Comment 8 Dominik Röttsches (drott) 2013-01-30 11:13:59 PST 
Thanks for the review, Tony.
Comment 9 WebKit Review Bot 2013-01-30 11:41:09 PST 
Comment on attachment 185503 [details]
Patch v3, Chromium buildfix.

Clearing flags on attachment: 185503

Committed r141291: <http://trac.webkit.org/changeset/141291>
Comment 10 WebKit Review Bot 2013-01-30 11:41:14 PST 
All reviewed patches have been landed.  Closing bug.