Bug 108165 - Revert an accidentally changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650.
Summary: Revert an accidentally changed line of EventHander::handleMousePressEvent(Pla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 103747
  Show dependency treegraph
 
Reported: 2013-01-29 01:02 PST by Hayato Ito
Modified: 2013-04-03 07:09 PDT (History)
3 users (show)

See Also:


Attachments
Revert the unintentional change. (1.32 KB, patch)
2013-01-29 01:14 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
Patch for landing (1.31 KB, patch)
2013-01-29 01:40 PST, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2013-01-29 01:02:35 PST
Let me revert one line change in http://trac.webkit.org/changeset/135650.

Please see the comment https://bugs.webkit.org/show_bug.cgi?id=103058#c9 for detail.
There aren't any layout tests that catch this change.

We should add a layout test, but there seems no way to detect the change from LayoutTests. I'll file another bug for that.
Comment 1 Hayato Ito 2013-01-29 01:14:25 PST
Created attachment 185194 [details]
Revert the unintentional change.
Comment 2 Hayato Ito 2013-01-29 01:23:42 PST
I've filed a bug in https://bugs.webkit.org/show_bug.cgi?id=108167
Comment 3 Hajime Morrita 2013-01-29 01:34:38 PST
Comment on attachment 185194 [details]
Revert the unintentional change.

View in context: https://bugs.webkit.org/attachment.cgi?id=185194&action=review

> Source/WebCore/ChangeLog:3
> +        Revert an unintentional changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650.

Nit: s/unintentional/unintentionally/ probably can be just said accidentally.
Comment 4 Hayato Ito 2013-01-29 01:39:12 PST
Thank you for the review. Let me land this after updating ChagneLog.

(In reply to comment #3)
> (From update of attachment 185194 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185194&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Revert an unintentional changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650.
> 
> Nit: s/unintentional/unintentionally/ probably can be just said accidentally.
Comment 5 Hayato Ito 2013-01-29 01:40:18 PST
Created attachment 185200 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-01-29 02:16:37 PST
Comment on attachment 185200 [details]
Patch for landing

Clearing flags on attachment: 185200

Committed r141088: <http://trac.webkit.org/changeset/141088>
Comment 7 WebKit Review Bot 2013-01-29 02:16:41 PST
All reviewed patches have been landed.  Closing bug.