Bug 108164 - Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from LayerTreeRenderer
Summary: Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from L...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108149
  Show dependency tree / graph
 
Reported: 2013-01-29 00:52 PST by Jae Hyun Park
Modified: 2013-01-30 21:23 PST (History)
7 users (show)

See Also:

Attachments
Patch (9.21 KB, patch)
2013-01-29 00:57 PST, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Patch (9.22 KB, patch)
2013-01-29 15:35 PST, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Patch (9.20 KB, patch)
2013-01-30 20:36 PST, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Hyun Park 2013-01-29 00:52:48 PST 
LayerTreeRenderer should not depend on CoordinatedLayerTreeHostProxy so that it can be moved to WebCore.
Comment 1 Jae Hyun Park 2013-01-29 00:57:27 PST 
Created attachment 185192 [details]
Patch
Comment 2 Build Bot 2013-01-29 08:53:46 PST 
Comment on attachment 185192 [details]
Patch

Attachment 185192 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16201189

New failing tests:
fast/workers/worker-document-leak.html
Comment 3 Caio Marcelo de Oliveira Filho 2013-01-29 12:00:52 PST 
LGTM.
Comment 4 Jae Hyun Park 2013-01-29 15:35:16 PST 
Created attachment 185322 [details]
Patch
Comment 5 Jae Hyun Park 2013-01-29 15:36:09 PST 
(In reply to comment #4)
> Created an attachment (id=185322) [details]
> Patch

Rebased.
Comment 6 Noam Rosenthal 2013-01-29 23:17:40 PST 
Comment on attachment 185322 [details]
Patch

LGTM, though a WK2 owner has to sign off.
Comment 7 Benjamin Poulain 2013-01-30 15:41:14 PST 
Comment on attachment 185322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185322&action=review

Okay from me given Noam already reviewed.

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:98
> +    // LayerTreeRendererClient Methods

Period.

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:98
> -    // The painting thread must lock the main thread to use below two methods, because two methods access members that the main thread manages. See m_coordinatedLayerTreeHostProxy.
> +    // The painting thread must lock the main thread to use below two methods, because two methods access members that the main thread manages. See m_client.
>      // Currently, QQuickWebPage::updatePaintNode() locks the main thread before calling both methods.
>      void purgeGLResources();
>      void setActive(bool);

This is backward. You should not document weird thread consistency issues, you should encapsulate them.
Comment 8 Jae Hyun Park 2013-01-30 20:36:27 PST 
Created attachment 185668 [details]
Patch
Comment 9 WebKit Review Bot 2013-01-30 21:23:34 PST 
Comment on attachment 185668 [details]
Patch

Clearing flags on attachment: 185668

Committed r141376: <http://trac.webkit.org/changeset/141376>
Comment 10 WebKit Review Bot 2013-01-30 21:23:38 PST 
All reviewed patches have been landed.  Closing bug.