RESOLVED FIXED 108161
Web Inspector: introduce HighlightDescriptor interface in DTE. 
https://bugs.webkit.org/show_bug.cgi?id=108161
Summary Web Inspector: introduce HighlightDescriptor interface in DTE.
Andrey Lushnikov
Reported 2013-01-29 00:26:26 PST
Introduce HighlightDescriptor interface and refactor highlight regex implementation to use RegexHighlightDescriptor class. This will make it possible to add "highlight range" functionality easily in future.
Attachments
Patch (7.96 KB, patch)
2013-01-29 00:31 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (13.00 KB, patch)
2013-01-29 04:08 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (13.01 KB, patch)
2013-01-29 07:30 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-01-29 00:31:25 PST
Created attachment 185185 [details] Patch
Pavel Feldman
Comment 2 2013-01-29 02:50:12 PST
Comment on attachment 185185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185185&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:1379 > + this._highlightDescriptors[regex] = highlightDescriptor; Now you should simply store it in the array. > Source/WebCore/inspector/front-end/DefaultTextEditor.js:1389 > + var result = delete this._highlightDescriptors[regex]; ... and remove it by instance. > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2661 > + testLine: function(lineNumber, line) { return false; }, Consider renaming - I can't tell what it does from its name.
Andrey Lushnikov
Comment 3 2013-01-29 04:08:05 PST
Created attachment 185216 [details] Patch
Pavel Feldman
Comment 4 2013-01-29 04:27:05 PST
Comment on attachment 185216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185216&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:1375 > + * @regex {WebInspector.TextEditorMainPanel.HighlightDescriptor} @return
Andrey Lushnikov
Comment 5 2013-01-29 07:30:14 PST
Created attachment 185244 [details] Patch
WebKit Review Bot
Comment 6 2013-01-29 07:53:34 PST
Comment on attachment 185244 [details] Patch Clearing flags on attachment: 185244 Committed r141111: <http://trac.webkit.org/changeset/141111>
WebKit Review Bot
Comment 7 2013-01-29 07:53:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.