Bug 108154 - IDBFactory::webkitGetDatabaseNames should raise DOMExceptions.
Summary: IDBFactory::webkitGetDatabaseNames should raise DOMExceptions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks: 94171
  Show dependency tree / graph
 
Reported: 2013-01-28 23:09 PST by Mike West
Modified: 2013-01-29 03:07 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.77 KB, patch)
2013-01-29 00:50 PST, Mike West 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-01-28 23:09:30 PST 
In order to properly support blocking third-party IndexedDB usage, ::open, ::getDatabaseNames, and ::deleteDatabase should all throw SECURITY_ERR when used in a blocked third-party context. Currently, ::getDatabaseNames doesn't support exceptions; we should change that.
Comment 1 Mike West 2013-01-29 00:50:49 PST 
Created attachment 185190 [details]
Patch
Comment 2 Mike West 2013-01-29 00:52:09 PST 
Is this something you'd be comfy reviewing, Jochen? See discussion on http://wkbug.com/94171, which is also where tests for this functionality will live. I'll update that patch to rebase on top of this one shortly.
Comment 3 jochen 2013-01-29 02:56:18 PST 
Comment on attachment 185190 [details]
Patch

r=me
Comment 4 Mike West 2013-01-29 02:59:42 PST 
Comment on attachment 185190 [details]
Patch

cq=me. Thanks. :)
Comment 5 WebKit Review Bot 2013-01-29 03:07:33 PST 
Comment on attachment 185190 [details]
Patch

Clearing flags on attachment: 185190

Committed r141090: <http://trac.webkit.org/changeset/141090>
Comment 6 WebKit Review Bot 2013-01-29 03:07:36 PST 
All reviewed patches have been landed.  Closing bug.