Bug 108142 - [Qt] Build fix
Summary: [Qt] Build fix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-28 18:16 PST by Jae Hyun Park
Modified: 2013-01-28 23:59 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.42 KB, patch)
2013-01-28 18:21 PST, Jae Hyun Park
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2013-01-28 18:27 PST, Jae Hyun Park
no flags Details | Formatted Diff | Diff
Patch for landing (1.57 KB, patch)
2013-01-28 20:08 PST, Jae Hyun Park
no flags Details | Formatted Diff | Diff
Patch for landing (2.10 KB, patch)
2013-01-28 22:23 PST, Jae Hyun Park
no flags Details | Formatted Diff | Diff
Patch (2.08 KB, patch)
2013-01-28 23:10 PST, Jae Hyun Park
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Hyun Park 2013-01-28 18:16:03 PST
StorageManager is not included in Target.pri and CMakeLists.txt
Comment 1 Jae Hyun Park 2013-01-28 18:21:36 PST
Created attachment 185126 [details]
Patch
Comment 2 Jae Hyun Park 2013-01-28 18:27:24 PST
Created attachment 185128 [details]
Patch
Comment 3 Gyuyoung Kim 2013-01-28 18:33:29 PST
Comment on attachment 185128 [details]
Patch

rs=me
Comment 4 Jae Hyun Park 2013-01-28 20:08:43 PST
Created attachment 185140 [details]
Patch for landing
Comment 5 Jae Hyun Park 2013-01-28 22:23:06 PST
Created attachment 185155 [details]
Patch for landing
Comment 6 Jae Hyun Park 2013-01-28 22:25:22 PST
I made a mistake and omitted to add UIProcess/Storage into INCLUDEPATH. The last patch fixes the build correctly.
Comment 7 WebKit Review Bot 2013-01-28 23:02:24 PST
Comment on attachment 185155 [details]
Patch for landing

Rejecting attachment 185155 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 185155, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16196006
Comment 8 Jae Hyun Park 2013-01-28 23:10:25 PST
Created attachment 185170 [details]
Patch
Comment 9 WebKit Review Bot 2013-01-28 23:59:17 PST
Comment on attachment 185170 [details]
Patch

Clearing flags on attachment: 185170

Committed r141068: <http://trac.webkit.org/changeset/141068>
Comment 10 WebKit Review Bot 2013-01-28 23:59:20 PST
All reviewed patches have been landed.  Closing bug.