Bug 108141 – FeatureObserver: Input types are counted unexpectedly in a page with Modernizr

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

http://modernizr.com/docs/#inputtypes

If the Input Types feature of Modernizr is loaded, FeatureObserver detects that all of the types are used.  It's not information which we want.

[Kent Tamura]

Modernizr's code follows.  It appends input elements to document.body, and attaches renderers.  Probably we should count "attached && visibility!=hidden"?

    function A() {
        e.inputtypes = function(a) {
            for (var d = 0, e, f, h, i = a.length; d < i; d++)
                k.setAttribute("type", f = a[d]),
                e = k.type !== "text",
                e && (k.value = l,
                      k.style.cssText = "position:absolute;visibility:hidden;",
                      /^range$/.test(f) && k.style.WebkitAppearance !== c ? (g.appendChild(k), h = b.defaultView, e = h.getComputedStyle && h.getComputedStyle(k, null).WebkitAppearance !== "textfield" && k.offsetHeight !== 0, g.removeChild(k)) : /^(search|tel)$/.test(f) || (/^(url|email)$/.test(f) ? e = k.checkValidity && k.checkValidity() === !1 : e = k.value != l)),
                o[a[d]] = !!e;
            return o
        }("search tel url email datetime date month week time datetime-local number range color".split(" "))
    }

[Kent Tamura]

Created attachment 185145 [details]
Patch

[Kentaro Hara]

Comment on attachment 185145 [details]
Patch

Makes sense to me.

[Build Bot]

Comment on attachment 185145 [details]
Patch

Attachment 185145 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16183019

[Kent Tamura]

Created attachment 185176 [details]
Patch for landing

Include NodeRenderStyle.h

[WebKit Review Bot]

Comment on attachment 185176 [details]
Patch for landing

Clearing flags on attachment: 185176

Committed r141086: <http://trac.webkit.org/changeset/141086>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.