Bug 108128 – [css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Bear Travis]

Created attachment 185092 [details]
Dynamically sets shape-inside after 5 seconds

See test file. After 5 seconds, a shape-inside is applied, but inline content is not laid out. Will relayout correctly if you zoom in/out.

[Bear Travis]

Created attachment 190659 [details]
Initial Patch

[Dave Hyatt]

Comment on attachment 190659 [details]
Initial Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190659&action=review

r-

> Source/WebCore/rendering/RenderBlock.cpp:1548
> +#if ENABLE(CSS_EXCLUSIONS)
> +    ExclusionShapeInsideInfo * info = exclusionShapeInsideInfo();
> +    if (info)
> +        info->setNeedsLayout(info->shapeSizeDirty());
> +    if (!relayoutChildren && (info || (info = layoutExclusionShapeInsideInfo())))
> +        relayoutChildren = info->needsLayout();
> +#endif

Could this possibly be folded into updateRegionsAndExclusionsLogicalSize, with that method returning a bool indicating whether or not relayoutChildren is required? Just trying to reduce the footprint of this code in layoutBlock.

[Bear Travis]

Created attachment 190988 [details]
Factoring code out of layoutBlock()

[Dave Hyatt]

Comment on attachment 190988 [details]
Factoring code out of layoutBlock()

r=me

[WebKit Review Bot]

Comment on attachment 190988 [details]
Factoring code out of layoutBlock()

Clearing flags on attachment: 190988

Committed r144487: <http://trac.webkit.org/changeset/144487>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.