Bug 108126 – WebKit2 should notify the client if the NetworkProcess crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

WebKit2 should notify the client if the NetworkProcess crashes

<rdar://problem/13090513>

[Brady Eidson]

Created attachment 185089 [details]
Patch v1

[Brady Eidson]

http://trac.webkit.org/changeset/141026

[Alexey Proskuryakov]

I don't think that adding this API this is desirable or necessary.

Network process crashing is not the only case when authentication request should be canceled. Another case is when NSURLConnection dispatches -connection:didCancelAuthenticationChallenge:. So, we need a code path for that, and crashing can be handled using that code path.

Exposing details of NetworkProcess lifecycle to clients seems unnecessary at this point.

[Brady Eidson]

(In reply to comment #3)
> I don't think that adding this API this is desirable or necessary.
> 
> Network process crashing is not the only case when authentication request should be canceled. Another case is when NSURLConnection dispatches -connection:didCancelAuthenticationChallenge:. So, we need a code path for that, and crashing can be handled using that code path.
> 
> Exposing details of NetworkProcess lifecycle to clients seems unnecessary at this point.

Sam and I have already had discussions by the couches for future uses of this API.  They seem valid and are symmetric with the value we get from notifying the client that a WebProcess crashed.

Feel free to ping me about them when you're back.

[Brady Eidson]

(In reply to comment #3)

> Network process crashing is not the only case when authentication request should be canceled. Another case is when NSURLConnection dispatches -connection:didCancelAuthenticationChallenge:. So, we need a code path for that, and crashing can be handled using that code path.

Also when you get back in, take a look at <rdar://problem/8773140>